You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Marcel Offermans (JIRA)" <ji...@apache.org> on 2006/04/05 15:27:51 UTC

[jira] Created: (FELIX-53) Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances

Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances
------------------------------------------------------------------------------------------------------------

         Key: FELIX-53
         URL: http://issues.apache.org/jira/browse/FELIX-53
     Project: Felix
        Type: Bug

    Reporter: Marcel Offermans
 Assigned to: Marcel Offermans 
    Priority: Minor


In ServiceImpl:

>>         else if ( getState() == ServiceMonitor.WAITING_FOR_REQUIRED )
>>         {
>>             // if we're waiting for required dependencies, then
>>             // we only need to stop tracking the dependency if it
>>             // too is required; this might trigger a state change

But! Contrary to my comments in the code I actually do not check if the  dependency is required, so that is an issue, because if it is an optional dependency and we're still waiting for the required dependencies, then this optional dependency will not have been started yet. That means we should not stop it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (FELIX-53) Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall closed FELIX-53.
--------------------------------


> Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-53
>                 URL: https://issues.apache.org/jira/browse/FELIX-53
>             Project: Felix
>          Issue Type: Bug
>          Components: Dependency Manager
>            Reporter: Marcel Offermans
>         Assigned To: Marcel Offermans
>            Priority: Minor
>
> In ServiceImpl:
> >>         else if ( getState() == ServiceMonitor.WAITING_FOR_REQUIRED )
> >>         {
> >>             // if we're waiting for required dependencies, then
> >>             // we only need to stop tracking the dependency if it
> >>             // too is required; this might trigger a state change
> But! Contrary to my comments in the code I actually do not check if the  dependency is required, so that is an issue, because if it is an optional dependency and we're still waiting for the required dependencies, then this optional dependency will not have been started yet. That means we should not stop it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-53) Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances

Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-53?page=all ]
     
Marcel Offermans resolved FELIX-53:
-----------------------------------

    Resolution: Fixed

Committed a fix for this problem (earlier).

> Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances
> ------------------------------------------------------------------------------------------------------------
>
>          Key: FELIX-53
>          URL: http://issues.apache.org/jira/browse/FELIX-53
>      Project: Felix
>         Type: Bug

>   Components: Dependency Manager
>     Reporter: Marcel Offermans
>     Assignee: Marcel Offermans
>     Priority: Minor

>
> In ServiceImpl:
> >>         else if ( getState() == ServiceMonitor.WAITING_FOR_REQUIRED )
> >>         {
> >>             // if we're waiting for required dependencies, then
> >>             // we only need to stop tracking the dependency if it
> >>             // too is required; this might trigger a state change
> But! Contrary to my comments in the code I actually do not check if the  dependency is required, so that is an issue, because if it is an optional dependency and we're still waiting for the required dependencies, then this optional dependency will not have been started yet. That means we should not stop it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FELIX-53) Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances

Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-53?page=all ]

Marcel Offermans updated FELIX-53:
----------------------------------

    Component: Dependency Manager

> Calling remove(dependency) on a service managed by the dependency manager fails under specific circumstances
> ------------------------------------------------------------------------------------------------------------
>
>          Key: FELIX-53
>          URL: http://issues.apache.org/jira/browse/FELIX-53
>      Project: Felix
>         Type: Bug

>   Components: Dependency Manager
>     Reporter: Marcel Offermans
>     Assignee: Marcel Offermans
>     Priority: Minor

>
> In ServiceImpl:
> >>         else if ( getState() == ServiceMonitor.WAITING_FOR_REQUIRED )
> >>         {
> >>             // if we're waiting for required dependencies, then
> >>             // we only need to stop tracking the dependency if it
> >>             // too is required; this might trigger a state change
> But! Contrary to my comments in the code I actually do not check if the  dependency is required, so that is an issue, because if it is an optional dependency and we're still waiting for the required dependencies, then this optional dependency will not have been started yet. That means we should not stop it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira