[GitHub] [netbeans] matthiasblaesing commented on pull request #5332: Improved collections usage. Part 1

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on PR #5332:
URL: https://github.com/apache/netbeans/pull/5332#issuecomment-1405270535

   >  Can i do migrate modules step by step to gradle?
   
   Short: No. Long: Changing the build system is a matter for all developers and needs to be discusses on the mailing list. There are multiple issues (for example there are people here, that think gradle is not a great build system) and there are already people out there, that tried to convert the build to gradle and have not yet succeeded. As said this is a major issue and at this point in time I'd veto any PR, that tries to introduce a mix of build systems.
   
   > dear, can i do PR's that removed some compile warnings or you also skip it?
   
   Not sure what you try to say. I can't speak for "we", but for me: I will look at PRs in the pace that I can manage, while also progressing "my" pet issues.  You can ask on the mailing list for more committers to look.
   
   At this point in time PRs that touch many file are a bad idea, as currently the release for 17 is being prepared (as announced on the mailing list).
   
   > Can i make supercommit with replacing " + " into "append" change there SB already used? 
   
   If you mean you want to change this:
   
   ```java
   StringBuilder sb = new StringBuilder();
   sb.append("Hallo" + "Welt");
   ```
   
   to
   
   ```java
   StringBuilder sb = new StringBuilder();
   sb.append("Hallo");
   sb.append("Welt");
   ```
   
   Sure. But remember: You need to motivate people to review. In my mind, if the code is not performance critical, the first form is not optimal, but works and thus does not need to change. If you fix a real bug and change it then, it is a different matter.
   
   All this is IMHO and others might feel differently.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists