You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/01/25 23:12:10 UTC

[GitHub] [druid] TSFenwick opened a new pull request #12202: add module test for QueryableModule

TSFenwick opened a new pull request #12202:
URL: https://github.com/apache/druid/pull/12202


   This will allow for better runtime.properties testing
   
   added a default GetRequestLoggerProviderTest and GetEmitterRequestLoggerProviderTest
   
   ### Description
   
   Add a unit test for Queryable Module to allow for easier testing of runtime.properties configs
   
   
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `QueryableModuleTest`
   
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [X] been self-reviewed.
   
   - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis merged pull request #12202: add module test for QueryableModule

Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #12202:
URL: https://github.com/apache/druid/pull/12202


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org