You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/05/01 18:15:55 UTC

Re: [PR] [SPARK-48016][SQL] Fix a bug in try_divide function when with decimals [spark]

dongjoon-hyun commented on PR #46286:
URL: https://github.com/apache/spark/pull/46286#issuecomment-2088871262

   Hi, @gengliangwang . 
   
   It's a little weird because
   - This PR doesn't contain `sql/core/src/test/resources/log4j2.properties`.
   - master commit also does.
   - branch-3.5 commit contains `sql/core/src/test/resources/log4j2.properties` whose content is suspicious.
      - https://github.com/apache/spark/commit/e78ee2c5770218a521340cb84f57a02dd00f7f3a
   ```
   - logger.parquet_outputcommitter.name = org.apache.parquet.hadoop.ParquetOutputCommitter
   + logger.parquet_outputcommitter.name = org.sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scalaapache.parquet.hadoop.ParquetOutputCommitter
   ```
   
   And, the above suspicious change broke `branch-3.5`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org