[jira] Updated: (NET-338) ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser with null systemName

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NET-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-338:
---------------------

    Component/s: FTP

> ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser with null systemName
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: NET-338
>                 URL: https://issues.apache.org/jira/browse/NET-338
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>            Reporter: Sebb
>
> ftp.FTPClient.initiateListParsing(String parserKey, String pathname) can call createFileEntryParser(String) with null systemName if the getSystemName() method fails.
> The resulting ParserInitializationException does not identify the cause.
> It would be better to throw a more specific error if the system name cannot be found.
> Ideally, getSystemName() should throw the error, but that would change the documented behaviour (null is specifically allowed as a return value).
> As it happens, getSystemName() is badly named, so one way forward is to create a new method getSystemType() which never returns null.
> Can then deprecate getSystemName().

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira