You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Eric Pugh (Jira)" <ji...@apache.org> on 2022/12/27 17:10:00 UTC
[jira] [Resolved] (SOLR-16583) Rename CloudSolrClientBuilder in SolrTestCaseJ4 to RandomizingCloudSolrClientBuilder
[ https://issues.apache.org/jira/browse/SOLR-16583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Pugh resolved SOLR-16583.
------------------------------
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
> Rename CloudSolrClientBuilder in SolrTestCaseJ4 to RandomizingCloudSolrClientBuilder
> ------------------------------------------------------------------------------------
>
> Key: SOLR-16583
> URL: https://issues.apache.org/jira/browse/SOLR-16583
> Project: Solr
> Issue Type: Sub-task
> Components: Integration Tests
> Affects Versions: 9.0
> Reporter: Eric Pugh
> Assignee: Eric Pugh
> Priority: Minor
> Fix For: main (10.0), 9.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I've been chasing may way through the confusion of various Builders, and to my dismay discovered that we have in SolrTestCaseJ4 defined a builder that is designed to do some randomization!
> {color:#cc7832}public static class {color}CloudSolrClientBuilder {color:#cc7832}extends {color}CloudLegacySolrClient.Builder
>
> This gets super confusing cause there is a test called CloudSolrClientBuilderTest that makes me think it tests the above class, but it doesnt'. in a previous commit we renamed a similar confusing pattern to
> RandomizingCloudHttp2SolrClientBuilder
> so this would be to clarify what this builder is.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org