You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/26 10:41:06 UTC
[GitHub] [doris] starocean999 opened a new pull request, #11212: [fix] the nullable info is lost in ifnull expr
starocean999 opened a new pull request, #11212:
URL: https://github.com/apache/doris/pull/11212
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
The ifnull(col_left, col_right) is converted to if(isnull(col_left), col_right, col_left). the col_left's nullable info is lost during converting.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11212: [fix] the nullable info is lost in ifnull expr
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11212:
URL: https://github.com/apache/doris/pull/11212#issuecomment-1195612167
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11212: [fix] the nullable info is lost in ifnull expr
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11212:
URL: https://github.com/apache/doris/pull/11212#issuecomment-1195612243
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #11212: [fix] the nullable info is lost in ifnull expr
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #11212:
URL: https://github.com/apache/doris/pull/11212#issuecomment-1195392540
Do you have any case to repeat the error?
```java
if (children.get(0).isNullable()) {
return children.get(1).isNullable();
}
```
The nullable here needs to be consistent with `FE`, I think we should do more change at `ifnull`.
This is the modification of get_return_type_impl, we also need to implement similar logic in execute_impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #11212: [fix] the nullable info is lost in ifnull expr
Posted by GitBox <gi...@apache.org>.
starocean999 commented on PR #11212:
URL: https://github.com/apache/doris/pull/11212#issuecomment-1198946020
> Do you have any case to repeat the error?
>
> ```java
> if (children.get(0).isNullable()) {
> return children.get(1).isNullable();
> }
> return false;
> ```
>
> The nullable here needs to be consistent with `FE`, I think we should do more change at `ifnull`. This is the modification of get_return_type_impl, we also need to implement similar logic in execute_impl 
thx, the be is modified and consistent with fe now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11212: [fix] the nullable info is lost in ifnull expr
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11212:
URL: https://github.com/apache/doris/pull/11212#issuecomment-1199025816
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #11212: [fix] the nullable info is lost in ifnull expr
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #11212:
URL: https://github.com/apache/doris/pull/11212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org