[GitHub] [cordova-android] breautek opened a new pull request #937: fix: GH-935 replaced compare-func with native sort method

[GitBox <gi...@apache.org>]

breautek opened a new pull request #937: fix: GH-935 replaced compare-func with native sort method
URL: https://github.com/apache/cordova-android/pull/937
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   `compare-func` & its sub-dependency `dot-prop` are two unmaintained packages with reported vulnerabilities as documented in #935 
   
   Closes #935
   
   ### Description
   <!-- Describe your changes in detail -->
   I removed the `compare-func` function and replaced its one and only usage in `ProjectBuilder` class using the native array `sort` method.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   The sort method was already tested, and the new sort implementation still passes the tests.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org