You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/22 06:54:38 UTC

[GitHub] [spark] wangyum commented on a change in pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide

wangyum commented on a change in pull request #31608:
URL: https://github.com/apache/spark/pull/31608#discussion_r580018130



##########
File path: docs/sql-migration-guide.md
##########
@@ -89,7 +89,7 @@ license: |
 
   - In Spark 3.0, `SHOW TBLPROPERTIES` throws `AnalysisException` if the table does not exist. In Spark version 2.4 and below, this scenario caused `NoSuchTableException`.
 
-  - In Spark 3.0, `SHOW CREATE TABLE` always returns Spark DDL, even when the given table is a Hive SerDe table. For generating Hive DDL, use `SHOW CREATE TABLE AS SERDE` command instead.
+  - In Spark 3.0, `SHOW CREATE TABLE table_identifier` always returns Spark DDL, even when the given table is a Hive SerDe table. For generating Hive DDL, use `SHOW CREATE TABLE table_identifier AS SERDE` command instead.

Review comment:
       +1. Otherwise, users will be confused whether it is `SHOW CREATE TABLE AS SERDE table_identifier` or `SHOW CREATE TABLE table_identifier AS SERDE`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org