[jira] [Closed] (TAP5-2217) JS modules from stack are not added when COMBINE_SCRIPTS is false

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-2217.
--------------------------------------

    Resolution: Won't Fix

I changed my mind; the two interpretations are incompatible and I feel that the new definition; that the module is pre-loaded as part of the virtual JavaScript asset, is the correct one.

It is very easy to have code automatically require the module; any component can do this via JavaScriptSupport.require().

> JS modules from stack are not added when COMBINE_SCRIPTS is false
> -----------------------------------------------------------------
>
>                 Key: TAP5-2217
>                 URL: https://issues.apache.org/jira/browse/TAP5-2217
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>            Assignee: Howard M. Lewis Ship
>            Priority: Blocker
>
> When COMBINE_SCRIPTS is set to {{false}}, a stack's modules are not added. The problem is that {{org.apache.tapestry5.internal.services.javascript.JavaScriptStackPathConstructorImpl.constructPathsForJavaScriptStack(String)}} only adds the stack's libraries if {{combineScripts}} is {{false}}.
> The problem was introduced in `65d31852d8b4a0691a19736c672fedea9e3179e0}}, by the removal of
> {code:java}
>         for (String moduleName : stack.getModules())
>         {
>             require(moduleName);
>         }
> {code}
> in {{org.apache.tapestry5.internal.services.ajax.JavaScriptSupportImpl.addAssetsFromStack(String)}}.



--
This message was sent by Atlassian JIRA
(v6.1#6144)