You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by diogojc <gi...@git.apache.org> on 2015/07/16 17:23:19 UTC
[GitHub] thrift pull request: (CSharp) Adding lifecycle management for serv...
GitHub user diogojc opened a pull request:
https://github.com/apache/thrift/pull/555
(CSharp) Adding lifecycle management for service handlers through TProcessorFactory
I want to be able to control the lifecycle of the instances implementing my thrift service handlers (TProcessor).
Before this change the behaviour for every Thrift server is that a service handler will always be the same instance throughout all requests and therefore would either need to be stateless or require thread safety.
I've replaced the TProcessor parameter in the constructors of TServer and subclasses, with a TProcessorFactory so this decision is postponed to the person creating the object graph by specifying a factory for the processors.
Please help me in figuring out what supporting things I need to change to reflect this that I haven't done yet.
Diogo.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/diogojc/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/555.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #555
----
commit 5eae1874669b19eb9baaffb30d3d59b7ea6fc805
Author: unknown <di...@tt-ltp-323.tamtam.nl>
Date: 2015-07-16T15:06:57Z
replacing TProcessor with TProcessorFactory so the lifecycle of processors are managed elsewhere
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #555: (CSharp) Adding lifecycle management for service handlers...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/555
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like it to be reconsidered.
---
[GitHub] thrift pull request: (CSharp) Adding lifecycle management for serv...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/555#issuecomment-188943128
Hi @diogojc, any news here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: (CSharp) Adding lifecycle management for serv...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/555#issuecomment-122078444
Nice idea. I'll take a look at it.
In the meantime, you may want to read our [contribution Guidelines](http://thrift.apache.org/docs/HowToContribute), if you did not do that already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #555: (CSharp) Adding lifecycle management for service handlers...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/555
@jfarrell recommend closing this PR. It was abandoned; no Jira ticket; author's fork has been destroyed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: (CSharp) Adding lifecycle management for serv...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/555#issuecomment-124849885
I think that's a good addition. But ... I'd like to have it even less breaking. Could you add some more CTORs with the **old** signature? Internally these would just wrap the passed processor into a singleton factory and then call the appropriate new CTOR version. What do you think?
This would automatoically resolve all issues with the tests and the tutorial code that we have right now.
And oh yes, [please create a JIRA issue](http://thrift.apache.org/docs/HowToContribute) for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #555: (CSharp) Adding lifecycle management for service h...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/555
---