You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/07 19:05:15 UTC
[GitHub] [tvm] comaniac opened a new pull request #7226: [AutoScheduler] Do not return naive schedule in tracing mode
comaniac opened a new pull request #7226:
URL: https://github.com/apache/tvm/pull/7226
We currently return an initial (naive) schedule in the tracing mode due to no tuned schedules. However, this won't work in the JIT mode, as the function will be compiled immediately after lowering. This PR changes this behavior by returning `None` in the tracing mode, so that the compile engine will fallback to use the default TOPI schedule.
Note: even with this PR, the strategy registered with naive schedule (i.e., NHWC Winograd Conv2D) still cannot work.
cc @merrymercy @jcf94
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a change in pull request #7226: [AutoScheduler] Do not return naive schedule in tracing mode
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #7226:
URL: https://github.com/apache/tvm/pull/7226#discussion_r553691384
##########
File path: python/tvm/auto_scheduler/relay_integration.py
##########
@@ -315,11 +315,10 @@ def auto_schedule_topi(outs):
new_key = json.dumps((new_dag.hash_key(),))
if new_key != key:
dispatch_ctx.update(target, new_key, state)
- return te.create_schedule([x.op for x in outs])
else:
raise ValueError("Invalid tracing mode: " + env.tracing_mode)
Review comment:
No, but if it reaches to this point then it must be something wrong with the code, because we should not expect an invalid tracing mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7226: [AutoScheduler] Do not return naive schedule in tracing mode
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7226:
URL: https://github.com/apache/tvm/pull/7226#issuecomment-756896071
Thanks @jcf94 @merrymercy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jcf94 commented on a change in pull request #7226: [AutoScheduler] Do not return naive schedule in tracing mode
Posted by GitBox <gi...@apache.org>.
jcf94 commented on a change in pull request #7226:
URL: https://github.com/apache/tvm/pull/7226#discussion_r553690488
##########
File path: python/tvm/auto_scheduler/relay_integration.py
##########
@@ -315,11 +315,10 @@ def auto_schedule_topi(outs):
new_key = json.dumps((new_dag.hash_key(),))
if new_key != key:
dispatch_ctx.update(target, new_key, state)
- return te.create_schedule([x.op for x in outs])
else:
raise ValueError("Invalid tracing mode: " + env.tracing_mode)
Review comment:
If program stop at this error exception, will the None return value take effect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #7226: [AutoScheduler] Do not return naive schedule in tracing mode
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7226:
URL: https://github.com/apache/tvm/pull/7226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #7226: [AutoScheduler] Do not return naive schedule in tracing mode
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7226:
URL: https://github.com/apache/tvm/pull/7226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7226: [AutoScheduler] Do not return naive schedule in tracing mode
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7226:
URL: https://github.com/apache/tvm/pull/7226#issuecomment-756896071
Thanks @jcf94 @merrymercy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org