[GitHub] [spark] MaxGekk commented on a diff in pull request #39873: [SPARK-42303][SQL] Assign name to _LEGACY_ERROR_TEMP_1326

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #39873:
URL: https://github.com/apache/spark/pull/39873#discussion_r1097333387


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -76,6 +76,13 @@
       "Could not load Protobuf class with name <protobufClassName>. <explanation>."
     ]
   },
+  "CANNOT_MODIFY_CONFIG" : {
+    "message" : [
+      "Cannot modify the value of a Spark config: <key>.",

Review Comment:
   nit:
   ```suggestion
         "Cannot modify the value of the Spark config: <key>.",
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -76,6 +76,13 @@
       "Could not load Protobuf class with name <protobufClassName>. <explanation>."
     ]
   },
+  "CANNOT_MODIFY_CONFIG" : {
+    "message" : [
+      "Cannot modify the value of a Spark config: <key>.",
+      "See also 'https://spark.apache.org/docs/latest/sql-migration-guide.html#ddl-statements'."

Review Comment:
   This one clashes with https://github.com/apache/spark/pull/39820, correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org