[GitHub] [incubator-eventmesh] jinrongluo commented on a change in pull request #772: [Issue #658] Eventmesh Http Support CloudEvents Webhook spec

[GitBox <gi...@apache.org>]

jinrongluo commented on a change in pull request #772:
URL: https://github.com/apache/incubator-eventmesh/pull/772#discussion_r813051326



##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/Constants.java
##########
@@ -35,7 +35,7 @@
 
     public static final String PROTOCOL_DESC = "protocoldesc";
 
-    public static final int DEFAULT_HTTP_TIME_OUT = 3000;
+    public static final int DEFAULT_HTTP_TIME_OUT = 15000;

Review comment:
       CloudEvents Webhook spec requires to Subscriber to implement Abuse Protection.  It means during the subscription, EventMesh needs to submit HTTP OPTIONS request to obtain the Delivery Consent . 
   
   That means the HTTP subscription request is taking a bit longer than 3000ms.
   
   So I increase the DEFAULT_HTTP_TIME_OUT
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org