You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/20 16:42:18 UTC
[GitHub] [activemq-artemis] 1984shekhar opened a new pull request #3037:
removed flag ' -l qpidtypes' from proton-cpp example
1984shekhar opened a new pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example
URL: https://github.com/apache/activemq-artemis/pull/3037
With '-l qpidtypes', error "/usr/bin/ld: cannot find -lqpidtypes" is received in console while executing compile.sh script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3037: removed flag '
-l qpidtypes' from proton-cpp example
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example
URL: https://github.com/apache/activemq-artemis/pull/3037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3037: removed flag ' -l qpidtypes' from proton-cpp example
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example
URL: https://github.com/apache/activemq-artemis/pull/3037#discussion_r395815650
##########
File path: examples/protocols/amqp/proton-cpp/compile.sh
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
# This requires g++ and qpid-cpp-client-devel
-g++ src/main/cpp/hello.cpp -o hello -l qpid-proton-cpp -l qpidtypes
Review comment:
can I understand why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] 1984shekhar commented on a change in pull
request #3037: removed flag ' -l qpidtypes' from proton-cpp example
Posted by GitBox <gi...@apache.org>.
1984shekhar commented on a change in pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example
URL: https://github.com/apache/activemq-artemis/pull/3037#discussion_r395953659
##########
File path: examples/protocols/amqp/proton-cpp/compile.sh
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
# This requires g++ and qpid-cpp-client-devel
-g++ src/main/cpp/hello.cpp -o hello -l qpid-proton-cpp -l qpidtypes
Review comment:
Hi clebert,
I don't find any qpidtypes shared library after installing qpid-proton-cpp client. Also I had discussion with Justin Ross on Red Hat messaging@redhat.com regarding this with subject "AMQ C++ Client". He suggested that qpidtypes should not be there.
List of available shared libraries:
[chandrashekhar@localhost lib64]$ pwd
/usr/lib64
[chandrashekhar@localhost lib64]$ ls -al|grep qpid
lrwxrwxrwx. 1 root root 25 Mar 3 00:58 libqpid-proton-core.so -> libqpid-proton-core.so.10
lrwxrwxrwx. 1 root root 29 Mar 3 00:58 libqpid-proton-core.so.10 -> libqpid-proton-core.so.10.8.1
-rwxr-xr-x. 1 root root 255408 Mar 3 00:58 libqpid-proton-core.so.10.8.1
lrwxrwxrwx. 1 root root 24 Mar 3 00:58 libqpid-proton-cpp.so -> libqpid-proton-cpp.so.12
lrwxrwxrwx. 1 root root 28 Mar 3 00:58 libqpid-proton-cpp.so.12 -> libqpid-proton-cpp.so.12.6.1
-rwxr-xr-x. 1 root root 421424 Mar 3 00:58 libqpid-proton-cpp.so.12.6.1
lrwxrwxrwx. 1 root root 28 Mar 3 00:58 libqpid-proton-proactor.so -> libqpid-proton-proactor.so.1
lrwxrwxrwx. 1 root root 32 Mar 3 00:58 libqpid-proton-proactor.so.1 -> libqpid-proton-proactor.so.1.5.1
-rwxr-xr-x. 1 root root 49288 Mar 3 00:58 libqpid-proton-proactor.so.1.5.1
lrwxrwxrwx. 1 root root 20 Mar 3 00:58 libqpid-proton.so -> libqpid-proton.so.11
lrwxrwxrwx. 1 root root 24 Mar 3 00:58 libqpid-proton.so.11 -> libqpid-proton.so.11.9.1
-rwxr-xr-x. 1 root root 368760 Mar 3 00:58 libqpid-proton.so.11.9.1
[chandrashekhar@localhost lib64]$
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3037: removed flag ' -l qpidtypes' from proton-cpp example
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example
URL: https://github.com/apache/activemq-artemis/pull/3037#discussion_r396047940
##########
File path: examples/protocols/amqp/proton-cpp/compile.sh
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
# This requires g++ and qpid-cpp-client-devel
-g++ src/main/cpp/hello.cpp -o hello -l qpid-proton-cpp -l qpidtypes
Review comment:
This is years old... it probably changed. thanks.. I will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] 1984shekhar commented on a change in pull
request #3037: removed flag ' -l qpidtypes' from proton-cpp example
Posted by GitBox <gi...@apache.org>.
1984shekhar commented on a change in pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example
URL: https://github.com/apache/activemq-artemis/pull/3037#discussion_r396064182
##########
File path: examples/protocols/amqp/proton-cpp/compile.sh
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
# This requires g++ and qpid-cpp-client-devel
-g++ src/main/cpp/hello.cpp -o hello -l qpid-proton-cpp -l qpidtypes
Review comment:
Thanks clebert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] gemmellr commented on a change in pull request
#3037: removed flag ' -l qpidtypes' from proton-cpp example
Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #3037: removed flag ' -l qpidtypes' from proton-cpp example
URL: https://github.com/apache/activemq-artemis/pull/3037#discussion_r396369056
##########
File path: examples/protocols/amqp/proton-cpp/compile.sh
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
# This requires g++ and qpid-cpp-client-devel
-g++ src/main/cpp/hello.cpp -o hello -l qpid-proton-cpp -l qpidtypes
Review comment:
While C++ is not my thing, I believe the only time I have seen qpidtypes referred to was with the older 'Qpid Messsaging' C++ client, i.e. its never been used for Proton and so should indeed be removed.
It looks like the example used the other client previously, since its even mentioned in the script on the line right above the change here, it says it requires qpid-cpp-client-devel rather than qpid-proton-cpp-devel.
Actually, the example readme also still discusses the other client extensively in its 'steps'. Seems like most of that should just be removed as it doesn't reflect the example at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services