You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/24 16:36:26 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request #970: Update to
add the camel-servicenow extension
zhfeng opened a new pull request #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970
Fix https://github.com/apache/camel-quarkus/issues/766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #970:
Update to add the camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970#discussion_r397419897
##########
File path: extensions/servicenow/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "ServiceNow"
+description: "The servicenow component is used to integrate Camel with ServiceNow cloud services."
+metadata:
+ keywords:
+ - "camel"
+ - "api"
+ - "cloud"
+ - "management"
+ guide: "https://quarkus.io/guides/camel"
+ categories:
+ - "integration"
+ status: "stable"
Review comment:
I have concerns how stable the CXF client will be in the native mode. We could perhaps use `preview` instead of `stable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #970:
Update to add the camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970#discussion_r397582276
##########
File path: integration-tests/servicenow/pom.xml
##########
@@ -0,0 +1,114 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-integration-tests</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-test-servicenow</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: ServiceNow</name>
+ <description>Integration tests for Camel Quarkus ServiceNow extension</description>
+
+ <properties>
+ <!-- mvnd, a.k.a. Maven Daemon: https://github.com/gnodet/mvnd -->
+ <!-- The following rule tells mvnd to build the listed deployment modules before this module. -->
+ <!-- This is important because mvnd builds modules in parallel by default. The deployment modules are not -->
+ <!-- explicit dependencies of this module in the Maven sense, although they are required by the Quarkus Maven plugin. -->
+ <!-- Please update rule whenever you change the dependencies of this module by running -->
+ <!-- mvn process-resources -Pformat from the root directory -->
+ <mvnd.builder.rule>camel-quarkus-servicenow-deployment,camel-quarkus-support-policy-deployment</mvnd.builder.rule>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-servicenow</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+
+ <!-- test dependencies -->
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-junit5</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.rest-assured</groupId>
+ <artifactId>rest-assured</artifactId>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>build</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>native</id>
+ <activation>
+ <property>
+ <name>native</name>
+ </property>
+ </activation>
+ <properties>
+ <quarkus.package.type>native</quarkus.package.type>
+ <quarkus.native.additional-build-args>-H:EnableURLProtocols=https</quarkus.native.additional-build-args>
Review comment:
Thanks for pointing it out !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #970:
Update to add the camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970#discussion_r397421958
##########
File path: integration-tests/servicenow/src/test/java/org/apache/camel/quarkus/component/servicenow/it/ServicenowIT.java
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.servicenow.it;
+
+import io.quarkus.test.junit.NativeImageTest;
+
+@NativeImageTest
Review comment:
```suggestion
@EnabledIfEnvironmentVariable(named = "SERVICENOW_INSTANCE", matches = ".+")
@EnabledIfEnvironmentVariable(named = "SERVICENOW_USERNAME", matches = ".+")
@EnabledIfEnvironmentVariable(named = "SERVICENOW_PASSWORD", matches = ".+")
@NativeImageTest
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #970:
Update to add the camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970#discussion_r397576519
##########
File path: extensions/servicenow/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "ServiceNow"
+description: "The servicenow component is used to integrate Camel with ServiceNow cloud services."
+metadata:
+ keywords:
+ - "camel"
+ - "api"
+ - "cloud"
+ - "management"
+ guide: "https://quarkus.io/guides/camel"
+ categories:
+ - "integration"
+ status: "stable"
Review comment:
I agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #970: Update to add the
camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970#issuecomment-603675325
> it might be safe to exclude these artifacts ?
Probably. Try it and if your tests pass, we are likely good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #970:
Update to add the camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970#discussion_r397424770
##########
File path: integration-tests/servicenow/pom.xml
##########
@@ -0,0 +1,114 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-integration-tests</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-test-servicenow</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: ServiceNow</name>
+ <description>Integration tests for Camel Quarkus ServiceNow extension</description>
+
+ <properties>
+ <!-- mvnd, a.k.a. Maven Daemon: https://github.com/gnodet/mvnd -->
+ <!-- The following rule tells mvnd to build the listed deployment modules before this module. -->
+ <!-- This is important because mvnd builds modules in parallel by default. The deployment modules are not -->
+ <!-- explicit dependencies of this module in the Maven sense, although they are required by the Quarkus Maven plugin. -->
+ <!-- Please update rule whenever you change the dependencies of this module by running -->
+ <!-- mvn process-resources -Pformat from the root directory -->
+ <mvnd.builder.rule>camel-quarkus-servicenow-deployment,camel-quarkus-support-policy-deployment</mvnd.builder.rule>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-servicenow</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+
+ <!-- test dependencies -->
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-junit5</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.rest-assured</groupId>
+ <artifactId>rest-assured</artifactId>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>build</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>native</id>
+ <activation>
+ <property>
+ <name>native</name>
+ </property>
+ </activation>
+ <properties>
+ <quarkus.package.type>native</quarkus.package.type>
+ <quarkus.native.additional-build-args>-H:EnableURLProtocols=https</quarkus.native.additional-build-args>
Review comment:
If https this is required for the regular case to work, then we should do the setting programmatically from the Processor by producing a `ExtensionSslNativeSupportBuildItem`, like we do e.g. here https://github.com/apache/camel-quarkus/blob/master/extensions/activemq/deployment/src/main/java/org/apache/camel/quarkus/component/activemq/deployment/ActiveMQProcessor.java#L40-L43
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #970: Update to add the
camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #970: Update to add the
camel-servicenow extension
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #970: Update to add the camel-servicenow extension
URL: https://github.com/apache/camel-quarkus/pull/970#issuecomment-603651936
In term of the "Dependency convergence" errors with jdk11 and jdk12
```
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (camel-quarkus-enforcer-rules) @ camel-quarkus-servicenow ---
[WARNING]
Dependency convergence error for javax.xml.soap:javax.xml.soap-api:1.4.0 paths to dependency are:
+-org.apache.camel.quarkus:camel-quarkus-servicenow:1.1.0-SNAPSHOT
+-org.apache.camel:camel-servicenow:3.1.0
+-org.apache.cxf:cxf-core:3.3.5
+-javax.xml.ws:jaxws-api:2.3.1
+-javax.xml.soap:javax.xml.soap-api:1.4.0
and
+-org.apache.camel.quarkus:camel-quarkus-servicenow:1.1.0-SNAPSHOT
+-org.apache.camel:camel-servicenow:3.1.0
+-org.apache.cxf:cxf-core:3.3.5
+-com.sun.xml.messaging.saaj:saaj-impl:1.4.0-b03
+-javax.xml.soap:javax.xml.soap-api:1.4.0-b01
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
Failed while enforcing releasability the error(s) are [
Dependency convergence error for javax.xml.soap:javax.xml.soap-api:1.4.0 paths to dependency are:
+-org.apache.camel.quarkus:camel-quarkus-servicenow:1.1.0-SNAPSHOT
+-org.apache.camel:camel-servicenow:3.1.0
+-org.apache.cxf:cxf-core:3.3.5
+-javax.xml.ws:jaxws-api:2.3.1
+-javax.xml.soap:javax.xml.soap-api:1.4.0
and
+-org.apache.camel.quarkus:camel-quarkus-servicenow:1.1.0-SNAPSHOT
+-org.apache.camel:camel-servicenow:3.1.0
+-org.apache.cxf:cxf-core:3.3.5
+-com.sun.xml.messaging.saaj:saaj-impl:1.4.0-b03
+-javax.xml.soap:javax.xml.soap-api:1.4.0-b01
```
It looks like an issue with the cxf 3.3.5 and had been fixed in the upstream when replacing to use the [jakarta api](https://github.com/apache/cxf/commit/6fabd55129e5bf6c0768a61aa649411dfdd98ddd#diff-04dc5d029560773ac79faaf3da0fbb22) in [CXF-7910 Change JAX-WS javax to jakarta artifact dependencies](https://issues.apache.org/jira/browse/CXF-7910) which will be included in the cxf 3.4.0 release plan.
Since the camel-servicenow does not use any ws transport, it might be safe to exclude these artifacts ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services