You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/20 11:51:24 UTC
[GitHub] [incubator-nuttx] pbrier opened a new pull request #4577: Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: Fixed IRQ link detection
pbrier opened a new pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577
## Summary
Added the DP83825I PHY (used on the teensy board) to the list of allowed PHYs for PHY interrupt detection. The source does not compile currently if this feature is selected, but all the required infrastructure is there.
## Impact
Source compiles as expected and link detection works on board that have this PHY and the interrupt connection. No side effects expected for other configurations.
## Testing
Configure nuttx for teensy 4.1 board and enable the PHY IRQ (CONFIG_NETDEV_PHY_IOCTL, IMXRT_GPIO_IRQ, CONFIG_ARCH_PHY_INTERRUPT, CONFIG_IMXRT_GPIO2_0_15_IRQ ) and CONFIG_NETINIT_MONITOR. The source should compile and now the link state should change when a cable is inserted or removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4577: Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: Fixed IRQ link detection
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577#discussion_r712111264
##########
File path: arch/arm/src/imxrt/imxrt_flexcan.c
##########
@@ -1455,7 +1455,7 @@ static int imxrt_ioctl(struct net_driver_s *dev, int cmd,
(FAR struct imxrt_driver_s *)dev->d_private;
int ret;
-
+ struct flexcan_timeseg data_timing;
Review comment:
Please move this struct declaration to above "int ret"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pbrier closed pull request #4577: Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: Fixed IRQ link detection
Posted by GitBox <gi...@apache.org>.
pbrier closed pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pbrier commented on pull request #4577: Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: Fixed IRQ link detection
Posted by GitBox <gi...@apache.org>.
pbrier commented on pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577#issuecomment-923344754
hmm. Have to study a bit more on this. In some configs ld is invoked (not needing the -Wl, option) and sometimes gcc is invoked as linker (needing the -Wl, option).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4577: Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: Fixed IRQ link detection
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577#issuecomment-922873167
Very nice @pbrier !!! Are you trying to run LaosLaser on Teensy board running NuttX ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pbrier commented on pull request #4577: Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: Fixed IRQ link detection
Posted by GitBox <gi...@apache.org>.
pbrier commented on pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577#issuecomment-923898196
Abandoning this one for individual PRs on the different issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pbrier commented on a change in pull request #4577: Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: Fixed IRQ link detection
Posted by GitBox <gi...@apache.org>.
pbrier commented on a change in pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577#discussion_r712121819
##########
File path: arch/arm/src/imxrt/imxrt_flexcan.c
##########
@@ -1455,7 +1455,7 @@ static int imxrt_ioctl(struct net_driver_s *dev, int cmd,
(FAR struct imxrt_driver_s *)dev->d_private;
int ret;
-
+ struct flexcan_timeseg data_timing;
Review comment:
@acassis No, this is for another project. But this definitely is a nice target for these kind of applications!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org