You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Vinod K V (JIRA)" <ji...@apache.org> on 2009/03/17 09:54:50 UTC
[jira] Created: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
TaskMemoryManagerThread crashes in a corner case
------------------------------------------------
Key: HADOOP-5516
URL: https://issues.apache.org/jira/browse/HADOOP-5516
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Affects Versions: 0.20.0
Reporter: Vinod K V
Priority: Blocker
TT's stdout says.
{code}
Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
{code}
TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5516) TaskMemoryManagerThread crashes in
a corner case
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683089#action_12683089 ]
Hudson commented on HADOOP-5516:
--------------------------------
Integrated in Hadoop-trunk #783 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/783/])
. Fix NullPointerException in TaskMemoryManagerThread that comes when monitored processes disappear when the thread is running. Contributed by Vinod Kumar Vavilapalli.
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt, HADOOP-5516-trunk-2.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod K V updated HADOOP-5516:
------------------------------
Attachment: HADOOP-5516-1.txt
This seems to happen when ProcfsBasedProcessTree.getProcessTree() when the root process is no longer alive. Attaching a patch for branch-0.20. This does the following:
- When the root process is not found, getProcessTree() method returns an empty process-tree.
- Added another null check in the same method when we cannot read process information from /proc vfs.
- Surrounded the memory management code of a single task with a try-catch block so that MemoryManager thread continues to function on other tasks even in the event of occurrence of uncaught exceptions on one task.
- Removed a spurious HashMap.put() inside an iterator on the same map processTreeInfoMap . This was pointed out by Hemanth.
- Modified test-case to verify that method calls on ProcfsBasedProcessTree are sane even if the process-tree is not alive or is gone.
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Attachments: HADOOP-5516-1.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5516) TaskMemoryManagerThread crashes in
a corner case
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682955#action_12682955 ]
Hadoop QA commented on HADOOP-5516:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12402394/HADOOP-5516-trunk-2.txt
against trunk revision 755426.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/99/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/99/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/99/console
This message is automatically generated.
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt, HADOOP-5516-trunk-2.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5516) TaskMemoryManagerThread crashes in
a corner case
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682659#action_12682659 ]
Hemanth Yamijala commented on HADOOP-5516:
------------------------------------------
Changes for 0.20 look good to me.
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod K V updated HADOOP-5516:
------------------------------
Attachment: HADOOP-5516-trunk-1.txt
Patch for trunk. In both the patches, the modified test-case should fail without the code changes and pass with them.
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod K V reassigned HADOOP-5516:
---------------------------------
Assignee: Vinod K V
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5516:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this to trunk and branch 0.20. Thanks, Vinod !
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt, HADOOP-5516-trunk-2.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5516) TaskMemoryManagerThread crashes in
a corner case
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682695#action_12682695 ]
Hemanth Yamijala commented on HADOOP-5516:
------------------------------------------
Changes look fine. +1.
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt, HADOOP-5516-trunk-2.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5516) TaskMemoryManagerThread crashes in
a corner case
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682666#action_12682666 ]
Hemanth Yamijala commented on HADOOP-5516:
------------------------------------------
Regarding changes in trunk, some minor nits:
- TaskMemoryManagerThread, there is an indentation problem in one of the comments, which is becoming very misleading. Search for "updated state"
- Same method, the call to pTree.destroy(); was pTree.destroy(true); in trunk. Though this is the default value for the overloaded API, I think it is better to retain the original code in case it changes in future.
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5516:
-------------------------------------
Description:
TT's stdout says.
{code}
Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
{code}
TaskMemoryManager crashes and no further memory management is done.
was:
TT's stdout says.
{code}
Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
{code}
TaskMemoryManager crashes and no further memory management is done.
Fix Version/s: 0.20.0
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5516:
-------------------------------------
Status: Patch Available (was: Open)
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt, HADOOP-5516-trunk-2.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5516) TaskMemoryManagerThread crashes in a
corner case
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod K V updated HADOOP-5516:
------------------------------
Attachment: HADOOP-5516-trunk-2.txt
Attaching patch for trunk incorporating the above comments. This passes `ant test-patch`
> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
> Key: HADOOP-5516
> URL: https://issues.apache.org/jira/browse/HADOOP-5516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Vinod K V
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt, HADOOP-5516-trunk-2.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" java.lang.NullPointerException
> at org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
> at org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.