You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "danwatford (via GitHub)" <gi...@apache.org> on 2023/02/07 22:10:52 UTC
[GitHub] [ofbiz-framework] danwatford opened a new pull request, #588: Fixed: Use ending balance from GlAccountHistory when calculating balance sheet balances (OFBIZ-12755)
danwatford opened a new pull request, #588:
URL: https://github.com/apache/ofbiz-framework/pull/588
GL Account balances including on the Balance Sheet now use the closing balance from the most recently closed time period's GlAccountHistory record, ensuring cumulative balances are calculated correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #588: Fixed: Use ending balance from GlAccountHistory when calculating balance sheet balances (OFBIZ-12755)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #588:
URL: https://github.com/apache/ofbiz-framework/pull/588#issuecomment-1421536369
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=588)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #588: Fixed: Use ending balance from GlAccountHistory when calculating balance sheet balances (OFBIZ-12755)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #588:
URL: https://github.com/apache/ofbiz-framework/pull/588#issuecomment-1424575946
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=588)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #588: Fixed: Use ending balance from GlAccountHistory when calculating balance sheet balances (OFBIZ-12755)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #588:
URL: https://github.com/apache/ofbiz-framework/pull/588#issuecomment-1424586596
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=588)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=588&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=588&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #588: Fixed: Use ending balance from GlAccountHistory when calculating balance sheet balances (OFBIZ-12755)
Posted by "gilPts (via GitHub)" <gi...@apache.org>.
gilPts commented on code in PR #588:
URL: https://github.com/apache/ofbiz-framework/pull/588#discussion_r1100146762
##########
applications/accounting/groovyScripts/reports/BalanceSheet.groovy:
##########
@@ -209,24 +204,15 @@ enum RootClass {DEBIT, CREDIT}
* This controls how the balance of the account is calculated:
* Debit account balance = totalDebits - totalCredits
* Credit account balance = totalCredits - totalDebits
- * @param Specify whether the opening account balances should be negated, having the effect of switching the credits
- * to debits, and vice-versa.
+ * @param negateBalances Specify whether balances should be negated after they have been calculated according to the
+ * debit/credit flag of any accounts for which transaction entries are found.
*/
def calculateBalances = { Map<String, AccountBalance> openingBalances,
Collection<String> accountClassIds,
RootClass rootClass,
- boolean negateOpeningBalances = false ->
-
- Map<String, AccountBalance> accountBalancesByGlAccountId = openingBalances.collectEntries {
- glAccountId, accountBalance ->
- [glAccountId, new AccountBalance(
- glAccountId: glAccountId,
- accountCode: accountBalance.accountCode,
- accountName: accountBalance.accountName,
- balance: negateOpeningBalances ? accountBalance.balance.negate() : accountBalance.balance,
- D: accountBalance.D,
- C: accountBalance.C,)]
- }
+ boolean negateBalances = false ->
+
+ def accountBalancesByGlAccountId = [:] as Map<String, AccountBalance> << openingBalances
Review Comment:
Another way of writing it :) https://groovy-lang.org/groovy-dev-kit.html#_spread_operator
```suggestion
Map<String, AccountBalance> accountBalancesByGlAccountId = [*:openingBalances]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford merged pull request #588: Fixed: Use ending balance from GlAccountHistory when calculating balance sheet balances (OFBIZ-12755)
Posted by "danwatford (via GitHub)" <gi...@apache.org>.
danwatford merged PR #588:
URL: https://github.com/apache/ofbiz-framework/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org