You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2026/01/28 18:26:52 UTC
[PR] chore: fix the pre-commit config to properly point at golangci-lint url [iceberg-go]
zeroshade opened a new pull request, #704:
URL: https://github.com/apache/iceberg-go/pull/704
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: fix the pre-commit config to properly point at golangci-lint url [iceberg-go]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #704:
URL: https://github.com/apache/iceberg-go/pull/704#discussion_r2738018375
##########
.pre-commit-config.yaml:
##########
@@ -18,9 +18,9 @@
files: ^go/
Review Comment:
i made a change to `exprs.go` locally, and ran pre-commit. it only worked after i removed this line 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: fix the pre-commit config to properly point at golangci-lint url [iceberg-go]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #704:
URL: https://github.com/apache/iceberg-go/pull/704#discussion_r2737994566
##########
.pre-commit-config.yaml:
##########
@@ -18,9 +18,9 @@
files: ^go/
Review Comment:
```suggestion
```
is this necessary? given the `types_or: [go]` below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: fix the pre-commit config to properly point at golangci-lint url [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #704:
URL: https://github.com/apache/iceberg-go/pull/704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: fix the pre-commit config to properly point at golangci-lint url [iceberg-go]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #704:
URL: https://github.com/apache/iceberg-go/pull/704#discussion_r2737994566
##########
.pre-commit-config.yaml:
##########
@@ -18,9 +18,9 @@
files: ^go/
Review Comment:
```suggestion
```
is this necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: fix the pre-commit config to properly point at golangci-lint url [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #704:
URL: https://github.com/apache/iceberg-go/pull/704#discussion_r2738337619
##########
.pre-commit-config.yaml:
##########
@@ -18,9 +18,9 @@
files: ^go/
Review Comment:
hmm, my bad you're right we should remove that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org