You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/22 07:48:08 UTC
[GitHub] [flink] godfreyhe commented on a change in pull request #13696: [FLINK-19726][table] Implement new providers for blink planner
godfreyhe commented on a change in pull request #13696:
URL: https://github.com/apache/flink/pull/13696#discussion_r509945463
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/sink/SinkNotNullEnforcer.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.sink;
+
+import org.apache.flink.api.common.functions.FilterFunction;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.api.config.ExecutionConfigOptions.NotNullEnforcer;
+import org.apache.flink.table.data.RowData;
+
+/**
+ * Checks writing null values into NOT NULL columns.
+ */
+public class SinkNotNullEnforcer implements FilterFunction<RowData> {
Review comment:
nit: add `serialVersionUID`
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/sink/SinkNotNullEnforcer.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.sink;
+
+import org.apache.flink.api.common.functions.FilterFunction;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.api.config.ExecutionConfigOptions.NotNullEnforcer;
+import org.apache.flink.table.data.RowData;
+
+/**
+ * Checks writing null values into NOT NULL columns.
+ */
+public class SinkNotNullEnforcer implements FilterFunction<RowData> {
+
+ private final NotNullEnforcer notNullEnforcer;
+ private final int[] notNullFieldIndices;
+ private final boolean notNullCheck;
+ private final String[] allFieldNames;
+
+ public SinkNotNullEnforcer(
+ NotNullEnforcer notNullEnforcer, int[] notNullFieldIndices, String[] allFieldNames) {
+ this.notNullFieldIndices = notNullFieldIndices;
+ this.notNullEnforcer = notNullEnforcer;
+ this.notNullCheck = notNullFieldIndices.length > 0;
+ this.allFieldNames = allFieldNames;
+ }
+
+ @Override
+ public boolean filter(RowData row) {
+ if (notNullCheck) {
Review comment:
nit: return `false` directly when notNullCheck is false, reduce nesting depth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org