You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/04/24 07:09:41 UTC
Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v agent,
vm is now gracefully shutting down
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6470
https://issues.apache.org/jira/browse/CLOUDSTACK-6470
Repository: cloudstack-git
Description
-------
When we stop VM in case of hyper-v, then it is always force shut downed i.e. turn off. Even if the integration services are installed in hyper-v. Directly turning of VM may result in corruption of disk. This patch fixes this issue. I have used new management class ShutdownComponent to achieve this.
Diffs
-----
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs PRE-CREATION
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 70ae8e8
Diff: https://reviews.apache.org/r/20651/diff/
Testing
-------
verified on my local setup by looking into the console of VM. When stopping the VM it shows that the shutdown process is initiated.
Thanks,
Anshul Gangwar
Re: Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v
agent, vm is now gracefully shutting down
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/#review41455
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On April 25, 2014, 8:28 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20651/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 8:28 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6470
> https://issues.apache.org/jira/browse/CLOUDSTACK-6470
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When we stop VM in case of hyper-v, then it is always force shut downed i.e. turn off. Even if the integration services are installed in hyper-v. Directly turning of VM may result in corruption of disk. This patch fixes this issue. I have used new management class ShutdownComponent to achieve this.
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs PRE-CREATION
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 70ae8e8
>
> Diff: https://reviews.apache.org/r/20651/diff/
>
>
> Testing
> -------
>
> verified on my local setup by looking into the console of VM. When stopping the VM it shows that the shutdown process is initiated.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v
agent, vm is now gracefully shutting down
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/#review41447
-----------------------------------------------------------
Commit 4a85e2226436c62e781db3449d262cb385b977c1 in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a85e22 ]
CLOUDSTACK-6470: while stopping vm in hyper-v, now we are first trying to shutdown it gracefully before turning it off forcefully
- ASF Subversion and Git Services
On April 25, 2014, 8:28 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20651/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 8:28 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6470
> https://issues.apache.org/jira/browse/CLOUDSTACK-6470
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When we stop VM in case of hyper-v, then it is always force shut downed i.e. turn off. Even if the integration services are installed in hyper-v. Directly turning of VM may result in corruption of disk. This patch fixes this issue. I have used new management class ShutdownComponent to achieve this.
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs PRE-CREATION
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 70ae8e8
>
> Diff: https://reviews.apache.org/r/20651/diff/
>
>
> Testing
> -------
>
> verified on my local setup by looking into the console of VM. When stopping the VM it shows that the shutdown process is initiated.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v
agent, vm is now gracefully shutting down
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/#review41450
-----------------------------------------------------------
Commit 1dc76a2743ae972642498f94d6f6a7ffd8067bf8 in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1dc76a2 ]
CLOUDSTACK-6470: while stopping vm in hyper-v, now we are first trying to shutdown it gracefully before turning it off forcefully
- ASF Subversion and Git Services
On April 25, 2014, 8:28 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20651/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 8:28 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6470
> https://issues.apache.org/jira/browse/CLOUDSTACK-6470
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When we stop VM in case of hyper-v, then it is always force shut downed i.e. turn off. Even if the integration services are installed in hyper-v. Directly turning of VM may result in corruption of disk. This patch fixes this issue. I have used new management class ShutdownComponent to achieve this.
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs PRE-CREATION
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 70ae8e8
>
> Diff: https://reviews.apache.org/r/20651/diff/
>
>
> Testing
> -------
>
> verified on my local setup by looking into the console of VM. When stopping the VM it shows that the shutdown process is initiated.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v
agent, vm is now gracefully shutting down
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/#review48854
-----------------------------------------------------------
Commit 48f9453a74c0dea9e3c57ab61515e29121c4d2d7 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=48f9453 ]
CLOUDSTACK-6470: while stopping vm in hyper-v, now we are first trying to shutdown it gracefully before turning it off forcefully
(cherry picked from commit 4a85e2226436c62e781db3449d262cb385b977c1)
Conflicts:
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs
- ASF Subversion and Git Services
On April 25, 2014, 8:28 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20651/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 8:28 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6470
> https://issues.apache.org/jira/browse/CLOUDSTACK-6470
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When we stop VM in case of hyper-v, then it is always force shut downed i.e. turn off. Even if the integration services are installed in hyper-v. Directly turning of VM may result in corruption of disk. This patch fixes this issue. I have used new management class ShutdownComponent to achieve this.
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs PRE-CREATION
> plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 70ae8e8
>
> Diff: https://reviews.apache.org/r/20651/diff/
>
>
> Testing
> -------
>
> verified on my local setup by looking into the console of VM. When stopping the VM it shows that the shutdown process is initiated.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v
agent, vm is now gracefully shutting down
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/
-----------------------------------------------------------
(Updated April 25, 2014, 8:28 a.m.)
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Changes
-------
updated the diff with some minor changes
Bugs: CLOUDSTACK-6470
https://issues.apache.org/jira/browse/CLOUDSTACK-6470
Repository: cloudstack-git
Description
-------
When we stop VM in case of hyper-v, then it is always force shut downed i.e. turn off. Even if the integration services are installed in hyper-v. Directly turning of VM may result in corruption of disk. This patch fixes this issue. I have used new management class ShutdownComponent to achieve this.
Diffs (updated)
-----
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs PRE-CREATION
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 70ae8e8
Diff: https://reviews.apache.org/r/20651/diff/
Testing
-------
verified on my local setup by looking into the console of VM. When stopping the VM it shows that the shutdown process is initiated.
Thanks,
Anshul Gangwar
Re: Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v
agent, vm is now gracefully shutting down
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/
-----------------------------------------------------------
(Updated April 24, 2014, 11:07 a.m.)
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Changes
-------
added the license header in newly created file
Bugs: CLOUDSTACK-6470
https://issues.apache.org/jira/browse/CLOUDSTACK-6470
Repository: cloudstack-git
Description
-------
When we stop VM in case of hyper-v, then it is always force shut downed i.e. turn off. Even if the integration services are installed in hyper-v. Directly turning of VM may result in corruption of disk. This patch fixes this issue. I have used new management class ShutdownComponent to achieve this.
Diffs (updated)
-----
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs PRE-CREATION
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 70ae8e8
Diff: https://reviews.apache.org/r/20651/diff/
Testing
-------
verified on my local setup by looking into the console of VM. When stopping the VM it shows that the shutdown process is initiated.
Thanks,
Anshul Gangwar