You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/05 20:46:17 UTC
[GitHub] [superset] amitmiran137 opened a new pull request #12976: Feat/dash rbac/single dashboard api
amitmiran137 opened a new pull request #12976:
URL: https://github.com/apache/superset/pull/12976
### SUMMARY
enforce access for a single dashboard on api.py endpoint
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `1.25%`.
> The diff coverage is `93.93%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 66.94% -1.26%
==========================================
Files 1025 489 -536
Lines 48765 28703 -20062
Branches 5188 0 -5188
==========================================
- Hits 33259 19215 -14044
+ Misses 15366 9488 -5878
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.94% <93.93%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <85.71%> (-0.52%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.44% <100.00%> (+0.81%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.62% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| ... and [565 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (e28d41a) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.10%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 62.09% -6.11%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28594 -4665
- Misses 15366 17453 +2087
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <ø> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.59% <94.11%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [434 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (02c53a0) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `15.59%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
===========================================
- Coverage 68.20% 52.60% -15.60%
===========================================
Files 1025 480 -545
Lines 48765 17315 -31450
Branches 5188 4485 -703
===========================================
- Hits 33259 9109 -24150
+ Misses 15366 8206 -7160
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.60% <ø> (+9.45%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [900 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12976:
URL: https://github.com/apache/superset/pull/12976#discussion_r571594962
##########
File path: superset/dashboards/api.py
##########
@@ -460,6 +477,101 @@ def bulk_delete(self, **kwargs: Any) -> Response:
except DashboardBulkDeleteFailedError as ex:
return self.response_422(message=str(ex))
+ @expose("/<int:pk>", methods=["GET"])
+ @protect()
+ @safe
+ @permission_name("get")
+ @rison(get_item_schema)
+ @check_dashboard_access(
+ dashboard_key="pk",
+ on_error=lambda self, ex: Response(
+ utils.error_msg_from_exception(ex), status=403
+ ),
+ )
+ @merge_response_func(
+ ModelRestApi.merge_show_label_columns, API_LABEL_COLUMNS_RIS_KEY
+ )
+ @merge_response_func(ModelRestApi.merge_show_columns, API_SHOW_COLUMNS_RIS_KEY)
+ @merge_response_func(
+ ModelRestApi.merge_description_columns, API_DESCRIPTION_COLUMNS_RIS_KEY
+ )
+ @merge_response_func(ModelRestApi.merge_show_title, API_SHOW_TITLE_RIS_KEY)
Review comment:
That's some stack of decorators
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (8433ac9) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `1.23%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 66.97% -1.24%
==========================================
Files 1025 489 -536
Lines 48765 28730 -20035
Branches 5188 0 -5188
==========================================
- Hits 33259 19241 -14018
+ Misses 15366 9489 -5877
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.97% <94.11%> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.77% <85.71%> (-3.65%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [557 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.08%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 62.11% -6.09%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28601 -4658
- Misses 15366 17446 +2080
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <ø> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.61% <94.11%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [430 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (49dddc6) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.09%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 62.10% -6.10%
==========================================
Files 1025 969 -56
Lines 48765 46043 -2722
Branches 5188 4485 -703
==========================================
- Hits 33259 28597 -4662
- Misses 15366 17446 +2080
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <52.72%> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.61% <94.66%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | `50.00% <0.00%> (-8.98%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/NewMenu.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9OZXdNZW51LnRzeA==) | `70.00% <ø> (-8.58%)` | :arrow_down: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `92.00% <ø> (+40.29%)` | :arrow_up: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `79.00% <ø> (+9.10%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `41.66% <0.00%> (-3.79%)` | :arrow_down: |
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (+27.27%)` | :arrow_up: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `88.00% <ø> (-4.99%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `88.23% <ø> (-5.89%)` | :arrow_down: |
| ... and [449 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...1091249](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `0.84%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 67.35% -0.85%
==========================================
Files 1025 489 -536
Lines 48765 28732 -20033
Branches 5188 0 -5188
==========================================
- Hits 33259 19352 -13907
+ Misses 15366 9380 -5986
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.35% <94.11%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.50%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| ... and [541 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (e28d41a) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.27%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 61.92% -6.28%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28516 -4743
- Misses 15366 17531 +2165
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <ø> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.32% <94.11%> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [437 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (1091249) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `1.26%`.
> The diff coverage is `93.65%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 66.94% -1.27%
==========================================
Files 1025 489 -536
Lines 48765 28700 -20065
Branches 5188 0 -5188
==========================================
- Hits 33259 19212 -14047
+ Misses 15366 9488 -5878
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.94% <93.65%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.77% <85.71%> (-3.65%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.29% <100.00%> (+0.65%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.62% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [563 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...1091249](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `0.88%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 67.31% -0.89%
==========================================
Files 1025 489 -536
Lines 48765 28732 -20033
Branches 5188 0 -5188
==========================================
- Hits 33259 19341 -13918
+ Misses 15366 9391 -5975
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.31% <94.11%> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <85.71%> (-0.52%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (e28d41a) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `0.88%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 67.32% -0.89%
==========================================
Files 1025 489 -536
Lines 48765 28732 -20033
Branches 5188 0 -5188
==========================================
- Hits 33259 19343 -13916
+ Misses 15366 9389 -5977
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.32% <94.11%> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (e28d41a) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.10%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 62.09% -6.11%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28595 -4664
- Misses 15366 17452 +2086
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <ø> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.59% <94.11%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [433 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (766fc58) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `1.20%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 66.99% -1.21%
==========================================
Files 1025 489 -536
Lines 48765 28730 -20035
Branches 5188 0 -5188
==========================================
- Hits 33259 19248 -14011
+ Misses 15366 9482 -5884
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.99% <94.11%> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.89% <85.71%> (-2.54%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [556 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...766fc58](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (e28d41a) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `5.63%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 62.57% -5.64%
==========================================
Files 1025 930 -95
Lines 48765 43557 -5208
Branches 5188 3959 -1229
==========================================
- Hits 33259 27254 -6005
- Misses 15366 16303 +937
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.36% <ø> (+10.21%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.32% <94.11%> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [451 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (1091249) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `0.81%`.
> The diff coverage is `93.75%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 67.39% -0.82%
==========================================
Files 1025 489 -536
Lines 48765 28728 -20037
Branches 5188 0 -5188
==========================================
- Hits 33259 19360 -13899
+ Misses 15366 9368 -5998
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.39% <93.75%> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.89% <85.71%> (-2.54%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.29% <100.00%> (+0.65%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [553 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...3703b52](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (8433ac9) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `1.22%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 66.97% -1.23%
==========================================
Files 1025 489 -536
Lines 48765 28732 -20033
Branches 5188 0 -5188
==========================================
- Hits 33259 19243 -14016
+ Misses 15366 9489 -5877
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.97% <94.11%> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.77% <85.71%> (-3.65%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [556 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (0331104) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `1.26%`.
> The diff coverage is `93.54%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 66.93% -1.27%
==========================================
Files 1025 489 -536
Lines 48765 28699 -20066
Branches 5188 0 -5188
==========================================
- Hits 33259 19211 -14048
+ Misses 15366 9488 -5878
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.93% <93.54%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <85.71%> (-0.52%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.24% <100.00%> (+0.60%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.62% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| ... and [565 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...3703b52](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.08%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 62.11% -6.09%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28602 -4657
- Misses 15366 17445 +2079
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <ø> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.62% <94.11%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [429 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774596690
@dpgaspar could you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.39%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 61.80% -6.40%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28461 -4798
- Misses 15366 17586 +2220
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.60% <ø> (+9.45%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.35% <94.11%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [433 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (e28d41a) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.41%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 61.78% -6.42%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28452 -4807
- Misses 15366 17595 +2229
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.60% <ø> (+9.45%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.32% <94.11%> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [437 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (e28d41a) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `0.96%`.
> The diff coverage is `94.02%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 67.23% -0.97%
==========================================
Files 1025 489 -536
Lines 48765 28704 -20061
Branches 5188 0 -5188
==========================================
- Hits 33259 19299 -13960
+ Misses 15366 9405 -5961
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.23% <94.02%> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.62% <100.00%> (-0.13%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [555 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12976:
URL: https://github.com/apache/superset/pull/12976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-775895778
> LGTM but, I prefer not add/merge this. I'm assuming you need HTTP 403 for some reason, but your previous work was already secure. I can argue that a response with HTTP 404 is actually more secure then HTTP 403 on this case, if an attacker brute scans the API with id's he can infer what id's actually exist and may be subject to some other form of attack. By using HTTP 404, what you see is what you get, and no additional information is given besides what the user has access to.
>
> Also code wise, the current new API on GET item, is based on this premise.
>
> Thoughts?
>
Ok then
Sounds legit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `5.53%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 62.66% -5.54%
==========================================
Files 1025 930 -95
Lines 48765 43557 -5208
Branches 5188 3959 -1229
==========================================
- Hits 33259 27294 -5965
- Misses 15366 16263 +897
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.57% <ø> (+10.41%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.35% <94.11%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [458 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (c592a27) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `6.25%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 68.20% 61.94% -6.26%
==========================================
Files 1025 969 -56
Lines 48765 46047 -2718
Branches 5188 4485 -703
==========================================
- Hits 33259 28525 -4734
- Misses 15366 17522 +2156
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <ø> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `67.35% <94.11%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.35% <85.71%> (-0.08%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.44% <86.95%> (-5.56%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.50% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `77.82% <100.00%> (+2.08%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [433 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...c592a27](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12976:
URL: https://github.com/apache/superset/pull/12976#discussion_r571608565
##########
File path: superset/dashboards/api.py
##########
@@ -460,6 +477,101 @@ def bulk_delete(self, **kwargs: Any) -> Response:
except DashboardBulkDeleteFailedError as ex:
return self.response_422(message=str(ex))
+ @expose("/<int:pk>", methods=["GET"])
+ @protect()
+ @safe
+ @permission_name("get")
+ @rison(get_item_schema)
+ @check_dashboard_access(
+ dashboard_key="pk",
+ on_error=lambda self, ex: Response(
+ utils.error_msg_from_exception(ex), status=403
+ ),
+ )
+ @merge_response_func(
+ ModelRestApi.merge_show_label_columns, API_LABEL_COLUMNS_RIS_KEY
+ )
+ @merge_response_func(ModelRestApi.merge_show_columns, API_SHOW_COLUMNS_RIS_KEY)
+ @merge_response_func(
+ ModelRestApi.merge_description_columns, API_DESCRIPTION_COLUMNS_RIS_KEY
+ )
+ @merge_response_func(ModelRestApi.merge_show_title, API_SHOW_TITLE_RIS_KEY)
Review comment:
remove all unessacary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12976: feat(dashboard_rbac): single dashboard api
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12976:
URL: https://github.com/apache/superset/pull/12976#issuecomment-774480413
# [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=h1) Report
> Merging [#12976](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=desc) (02c53a0) into [master](https://codecov.io/gh/apache/superset/commit/137cf5d4d91bef954f733684f4e1f8573049be0b?el=desc) (137cf5d) will **decrease** coverage by `15.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12976 +/- ##
===========================================
- Coverage 68.20% 52.97% -15.23%
===========================================
Files 1025 480 -545
Lines 48765 17315 -31450
Branches 5188 4485 -703
===========================================
- Hits 33259 9173 -24086
+ Misses 15366 8142 -7224
+ Partials 140 0 -140
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.97% <ø> (+9.82%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `40.00% <ø> (+16.00%)` | :arrow_up: |
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `32.55% <ø> (+16.55%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [900 more](https://codecov.io/gh/apache/superset/pull/12976/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=footer). Last update [b472d18...02c53a0](https://codecov.io/gh/apache/superset/pull/12976?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org