[GitHub] [tvm] echuraev commented on a diff in pull request #14792: [OpenCL] Refactor OpenCL runtime to support SPIRV binary ingestion

["echuraev (via GitHub)" <gi...@apache.org>]

echuraev commented on code in PR #14792:
URL: https://github.com/apache/tvm/pull/14792#discussion_r1187015136


##########
src/runtime/opencl/opencl_module.cc:
##########
@@ -108,7 +109,27 @@ class OpenCLWrappedFunc {
   LaunchParamConfig launch_param_config_;
 };
 
-OpenCLModuleNode::~OpenCLModuleNode() {
+class OpenCLSPIRVModuleNode : public OpenCLModuleNodeBase {

Review Comment:
   Probably all runtime part related to SPIRV can be moved in a new directory in `src/runtime`? I suppose that SPIRV can be useful no only for Vulcan, so SPIRV can be separated from other runtimes initially. What do you think?



##########
src/target/source/codegen_opencl.cc:
##########
@@ -585,6 +586,14 @@ void CodeGenOpenCL::SetTextureScope(
 }
 
 runtime::Module BuildOpenCL(IRModule mod, Target target) {
+#if TVM_USE_VULKAN

Review Comment:
   Probably this variable can be device-agnostic? Like: `TVM_USE_SPIRV` or something like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org