You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/07/26 02:48:48 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

Apache9 commented on a change in pull request #3499:
URL: https://github.com/apache/hbase/pull/3499#discussion_r676255322



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
##########
@@ -409,6 +432,18 @@ void loadTableCoprocessors(final Configuration conf) {
   @Override
   public RegionEnvironment createEnvironment(RegionCoprocessor instance, int priority, int seq,
       Configuration conf) {
+    if (coprocessorService instanceof HCompactionServer) {

Review comment:
       Could we add some configs to avoid instanceof here, or we sub class RegionCoprocessorHost?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org