[jira] [Comment Edited] (CAY-2008) Connection pool refactoring and validation query support in Cayenne DataSource

["Andrus Adamchik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAY-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521689#comment-14521689 ] 

Andrus Adamchik edited comment on CAY-2008 at 4/30/15 3:47 PM:
---------------------------------------------------------------

The actual refactoring and changes committed:

    * Refactoring and cleanup of DataSource implementation
    * DataSourceBuilder
    * splitting pool management thread into a separate DS wrapper
    * implementing java.sql.Wrapper methods
    * pool specific parameters are passed as a special object
    * stop supporting getting connections with expclicit username/password. We do not have any notion of per-user connection pools, so it is only misleading and can lead  to unpredictable pool state
    * validate query


was (Author: andrus):
The actual refactoring and changes committed:

    * Refactoring and cleanup of DataSource implementation
    * DataSourceBuilder
    * splitting pool management thread into a separate DS wrapper
    * implementing java.sql.Wrapper methods
    * pool specific parameters are passed as a special object
    * stop supporting getting connections with expclicit username/password. We do not have any
      notion of per-user connection pools, so it is only misleading and can lead
      to unpredictable pool state
    * validate query

> Connection pool refactoring and validation query support in Cayenne DataSource
> ------------------------------------------------------------------------------
>
>                 Key: CAY-2008
>                 URL: https://issues.apache.org/jira/browse/CAY-2008
>             Project: Cayenne
>          Issue Type: Bug
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>
> While I am normally of an opinion that our own connection pool should not compete with 3rd parties, and we should instead focus on ORM features of the framework, I ran into a few scenarios that made me reconsider and work on adding at least some features. 
> Specifically "validation query" that is run before a connection is given to the pool user is a must have. Otherwise the user gets timed out connections. So arguably the pool is broken as a result.
> While we are at it, we might rename connection pool classes, and provide a builder for the pool. PoolManager is not the most intuitive name for the pooling DataSource and its construction API is far from easy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)