You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Malinda Kaushalye Kapuruge (JIRA)" <ji...@apache.org> on 2006/11/08 08:02:51 UTC
[jira] Commented: (AXIS2C-397) Rampart Utils - Some Code
Improvements
[ http://issues.apache.org/jira/browse/AXIS2C-397?page=comments#action_12448058 ]
Malinda Kaushalye Kapuruge commented on AXIS2C-397:
---------------------------------------------------
Thanks for pointing this out.
1. I have comitted a code that I used to debug :) Anyway I'll rectify it asap.
2 & 3. This code is not in use for UsernameToken and Timestamp functionalities. I'm using this for debugigng the encryption.
> Rampart Utils - Some Code Improvements
> --------------------------------------
>
> Key: AXIS2C-397
> URL: http://issues.apache.org/jira/browse/AXIS2C-397
> Project: Axis2-C
> Issue Type: Improvement
> Components: rampart
> Affects Versions: Current (Nightly)
> Environment: All
> Reporter: Nabeel Yoosuf
> Assigned To: Malinda Kaushalye Kapuruge
> Priority: Minor
>
> I had a quick glance at some of the files in rampart utils..Some suggestions
> 1. In some functions the same value is recalculated several times which is not efficient.
> E.g.
> rampart_utils.c:rampart_generate_nonce(..)
> OXS_BUFFER_GET_SIZE(buffer, env)
> rampart_cryto_utils.c:rampart_crypto_sha1(..)
> axis2_base64_decode_len(nonce)
> 2. Memory leaks
> E.g.
> rampart_crypt_utils.c:45 - what is allocated is not freed
> 3. I find many printf's - are these for debugging? the better way is to perform a runtime debugging.
> Thanks
> -Nabeel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org