You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2025/02/03 14:05:34 UTC
[Impala-ASF-CR] IMPALA-13672: Migrate query test/test kudu.py to use hs2 protocol
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22358 )
Change subject: IMPALA-13672: Migrate query_test/test_kudu.py to use hs2 protocol
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22358/8/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/22358/8/tests/query_test/test_kudu.py@169
PS8, Line 169: execute_query_using_vector
it is not clear to me why do we need execute_query_using_vector - would simple execute be enough with default HS2 client?
http://gerrit.cloudera.org:8080/#/c/22358/8/tests/query_test/test_kudu.py@1438
PS8, Line 1438: assert result.data == [
: "a\tint\t\ttrue\ttrue\tfalse\t\tAUTO_ENCODING\tDEFAULT_COMPRESSION\t0"]
Can we assume that this will be always run with hs2 protocol? In that case these rewrites could be avoided by using result.__result_tuples directly: https://github.com/apache/impala/blob/8d74bfd18cbdd63f2497fc007ffaa4ee0fadc270/tests/common/impala_connection.py#L568C10-L568C25
If we are moving towards dropping beeswax from tests then it seems a good idea to me to store the original results and use whichever result type (tuple/tsv) is simpler in the given test.
--
To view, visit http://gerrit.cloudera.org:8080/22358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f38baf5a0bbde1a1ad0bb4666c300f4f3cabd33
Gerrit-Change-Number: 22358
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 14:05:34 +0000
Gerrit-HasComments: Yes