You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/08/25 04:47:11 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42671: [SPARK-44958][PYTHON][CONNECT][TESTS] Add a test to validate the parity of functions
zhengruifeng opened a new pull request, #42671:
URL: https://github.com/apache/spark/pull/42671
### What changes were proposed in this pull request?
Add a test to validate the parity of functions
### Why are the changes needed?
there is a test to compare the functions between PySpark and JVM side, but we don't have one to compare PySpark vs Spark Connect
### Does this PR introduce _any_ user-facing change?
no, test-only
### How was this patch tested?
added UT
### Was this patch authored or co-authored using generative AI tooling?
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42671: [SPARK-44958][PYTHON][CONNECT][TESTS] Add a test to validate the parity of functions
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42671:
URL: https://github.com/apache/spark/pull/42671#discussion_r1305132855
##########
python/pyspark/sql/connect/functions.py:
##########
@@ -744,6 +744,9 @@ def pow(col1: Union["ColumnOrName", float], col2: Union["ColumnOrName", float])
pow.__doc__ = pysparkfuncs.pow.__doc__
+power = pow
Review Comment:
this alias is not exposed to end users at all, add here just for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42671: [SPARK-44958][PYTHON][CONNECT][TESTS] Add a test to validate the parity of functions
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42671: [SPARK-44958][PYTHON][CONNECT][TESTS] Add a test to validate the parity of functions
URL: https://github.com/apache/spark/pull/42671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42671: [SPARK-44958][PYTHON][CONNECT][TESTS] Add a test to validate the parity of functions
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42671:
URL: https://github.com/apache/spark/pull/42671#discussion_r1305132855
##########
python/pyspark/sql/connect/functions.py:
##########
@@ -744,6 +744,9 @@ def pow(col1: Union["ColumnOrName", float], col2: Union["ColumnOrName", float])
pow.__doc__ = pysparkfuncs.pow.__doc__
+power = pow
Review Comment:
this alias is not exposed to end users at all, add here for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42671: [SPARK-44958][PYTHON][CONNECT][TESTS] Add a test to validate the parity of functions
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42671:
URL: https://github.com/apache/spark/pull/42671#issuecomment-1693161279
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42671: [SPARK-44958][PYTHON][CONNECT][TESTS] Add a test to validate the parity of functions
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42671:
URL: https://github.com/apache/spark/pull/42671#issuecomment-1692756817
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org