[GitHub] [lucene] vigyasharma commented on issue #12082: LeafFieldComparator setBottom not being called before compareBottom

[GitBox <gi...@apache.org>]

vigyasharma commented on issue #12082:
URL: https://github.com/apache/lucene/issues/12082#issuecomment-1396549638

   I think you're right that `bottom` should be scoped outside the `LeafFieldComparator`. It stores the bottom slot value for competitive hits and should survive across leaf contexts.
   
   I checked a few FieldComparator implementations however, and I do see  it scoped outside the LeafFieldComparator. For e.g. [DoubleComparator](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java#L32), and [DocComparator](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java#L31)
   
   This also seems to be the case in Lucene 8.11.2 ([[1]](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.2/lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java#L33), [[2]](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.2/lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java#L34))
   
   Can you share code references/links for some comparators where you see this is an issue? Or perhaps a test which reproduces this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org