You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/04 03:02:54 UTC

[GitHub] [spark] bzhaoopenstack commented on pull request #37369: [SPARK-39942][PYTHON][PS] Need to verify the input nums is integer in nsmallest func

bzhaoopenstack commented on PR #37369:
URL: https://github.com/apache/spark/pull/37369#issuecomment-1204701311

   > I'm not sure about @Yikun 's `type_checker` annotation, but it seems simpler than manually adding `isinstance` checking for each parameter.
   The code looks checking the definition of annotation, as make it as a decorator and using typing to checking during runtime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org