You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Ismael Juma (JIRA)" <ji...@apache.org> on 2016/09/09 20:42:20 UTC
[jira] [Commented] (KAFKA-4145) Avoid redundant integration testing
in ProducerSendTests
[ https://issues.apache.org/jira/browse/KAFKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478195#comment-15478195 ]
Ismael Juma commented on KAFKA-4145:
------------------------------------
I am not sure about the `testClose` ones. It seems like it would be good to test that with SSL as well. We should have a few `send` tests that are tested with multiple protocols.
> Avoid redundant integration testing in ProducerSendTests
> --------------------------------------------------------
>
> Key: KAFKA-4145
> URL: https://issues.apache.org/jira/browse/KAFKA-4145
> Project: Kafka
> Issue Type: Improvement
> Components: unit tests
> Reporter: Jason Gustafson
> Assignee: Vahid Hashemian
>
> We have a few test cases in {{BaseProducerSendTest}} which probably have little value being tested for both Plaintext and SSL. We can move them to {{PlaintextProducerSendTest}} and save a little bit on the build time. The following tests seem like possible candidates:
> 1. testSendCompressedMessageWithCreateTime
> 2. testSendNonCompressedMessageWithCreateTime
> 3. testSendCompressedMessageWithLogAppendTime
> 4. testSendNonCompressedMessageWithLogApendTime
> 5. testAutoCreateTopic
> 6. testFlush
> 7. testSendWithInvalidCreateTime
> 8. testCloseWithZeroTimeoutFromCallerThread
> 9. testCloseWithZeroTimeoutFromSenderThread
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)