You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/02/18 01:58:58 UTC
[GitHub] [incubator-datasketches-cpp] jmalkin commented on issue #87: Varopt
Sampling
jmalkin commented on issue #87: Varopt Sampling
URL: https://github.com/apache/incubator-datasketches-cpp/pull/87#issuecomment-587237414
addressed everything bu the asserts.
i think std::allocator::construct() is dfeprecated in favor of the one in allocator_traits so I'm tempted to replace it with placement new everywhere, except that then you can't override with a custom constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org