You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/29 09:58:40 UTC
[GitHub] [maven] nielsbasjes opened a new pull request #483: [MSHADE-326] Remove bad workspace cache which caused problems in maven-shade-plugin
nielsbasjes opened a new pull request #483:
URL: https://github.com/apache/maven/pull/483
This is a proposed merge request that came from the discussion of
https://github.com/apache/maven-shade-plugin/pull/26
https://issues.apache.org/jira/browse/MSHADE-326
Essentially the discussion (with @michael-o @rfscholte) came to the point where it seemed that the rootcause of the problem in the maven-shade-plugin was really a problem in maven itself where it does not reload the changes in the project (after shade modified it) thus causing incorrect data to be read in the rest of a multi-module project.
This simply removes this "skip cache refresh" code (that was originally annotated as a hack!)
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it).
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #483: [MSHADE-326] Remove bad workspace cache which caused problems in maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #483:
URL: https://github.com/apache/maven/pull/483#issuecomment-870507465
@michael-o How can MNG-6638 be tested? Looking at the changes for this I only see some additional code in `MavenMetadataSource.java` that retrieves some existing data, no tests (and the removal of the `hack` comment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #483: [MSHADE-326] Remove bad workspace cache which caused problems in maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #483:
URL: https://github.com/apache/maven/pull/483#issuecomment-870458637
We will also need to reconsider MNG-6638 becaue we cannot drop this cache with fixing MNG-6638. We obviously need to check whether this is stale..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #483: [MSHADE-326] Remove bad workspace cache which caused problems in maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #483:
URL: https://github.com/apache/maven/pull/483#issuecomment-870507877
The only test that failed in CI is `MavenITmng5895CIFriendlyUsageWithPropertyTest` and it only fails on Windows with Java 8.
Looking at the original issue https://issues.apache.org/jira/browse/MNG-5895 (fixed about 4 years ago) there is a comment from December 2020 that seems to indicate problems on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #483: [MSHADE-326] Remove bad workspace cache which caused problems in maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #483:
URL: https://github.com/apache/maven/pull/483#issuecomment-870507465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #483: [MSHADE-326] Remove bad workspace cache which caused problems in maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #483:
URL: https://github.com/apache/maven/pull/483#issuecomment-870458637
We will also need to reconsider MNG-6638 becaue we cannot drop this cache with fixing MNG-6638. We obviously need to check whether this is stale..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org