You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "Tobias Rettstadt (JIRA)" <ji...@apache.org> on 2015/02/05 11:04:34 UTC

[jira] [Created] (DELTASPIKE-831) NPE in DefaultMockFilter when running JUnit and the application contains a class in the default package

Tobias Rettstadt created DELTASPIKE-831:
-------------------------------------------

             Summary: NPE in DefaultMockFilter when running JUnit and the application contains a class in the default package
                 Key: DELTASPIKE-831
                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-831
             Project: DeltaSpike
          Issue Type: Bug
          Components: TestControl
    Affects Versions: 1.2.1
         Environment: JUnit+Deltaspike+OpenEJB 4.6.0 on Windows 7, Oracle JDK 7
            Reporter: Tobias Rettstadt


Running a unit test results in a NPE if the application contains a class in the default package. The problem is line 67 of {{org.apache.deltaspike.testcontrol.impl.mock.DefaultMockFilter}} where
{{isInternalPackage(origin.getPackage().getName())}} is called without checking if {{getPackage()}} returns null.

Suggested fix: Change line 67 to
{code}
        return origin != null && (origin.getPackage() == null || !isInternalPackage(origin.getPackage().getName()));
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)