You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2023/12/11 05:02:30 UTC
[PR] [SPARK-46357] Replace incorrect documentation use of setConf with conf.set [spark]
nchammas opened a new pull request, #44290:
URL: https://github.com/apache/spark/pull/44290
### What changes were proposed in this pull request?
`setConf` is a method on `SQLContext`. The docs perhaps used to refer to `SQLContext`, but now they refer to `SparkSession`, which does not have this method.
This PR updates the docs to use the appropriate method for making configuration settings against `SparkSession`.
### Why are the changes needed?
The current documentation is incorrect.
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
No testing.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46357] Replace incorrect documentation use of setConf with conf.set [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44290:
URL: https://github.com/apache/spark/pull/44290#issuecomment-1855052192
Thanks @nchammas, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46357] Replace incorrect documentation use of setConf with conf.set [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44290:
URL: https://github.com/apache/spark/pull/44290#issuecomment-1850508338
cc @gengliangwang for this minor documentation fix. (I just picked you since I see you recently worked on this file. Let me know if that's not appropriate.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46357] Replace incorrect documentation use of setConf with conf.set [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #44290: [SPARK-46357] Replace incorrect documentation use of setConf with conf.set
URL: https://github.com/apache/spark/pull/44290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46357] Replace incorrect documentation use of setConf with conf.set [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #44290:
URL: https://github.com/apache/spark/pull/44290#discussion_r1423771440
##########
docs/sql-performance-tuning.md:
##########
@@ -31,7 +31,7 @@ Spark SQL can cache tables using an in-memory columnar format by calling `spark.
Then Spark SQL will scan only required columns and will automatically tune compression to minimize
memory usage and GC pressure. You can call `spark.catalog.uncacheTable("tableName")` or `dataFrame.unpersist()` to remove the table from memory.
-Configuration of in-memory caching can be done using the `setConf` method on `SparkSession` or by running
+Configuration of in-memory caching can be done via `SparkSession.conf.set` or by running
Review Comment:
nit: Like lines 30 and 32, use `spark.conf.set`?
##########
docs/sql-data-sources-parquet.md:
##########
@@ -431,7 +431,7 @@ Other generic options can be found in <a href="https://spark.apache.org/docs/lat
### Configuration
-Configuration of Parquet can be done using the `setConf` method on `SparkSession` or by running
+Configuration of Parquet can be done via `SparkSession.conf.set` or by running
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46357] Replace incorrect documentation use of setConf with conf.set [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44290:
URL: https://github.com/apache/spark/pull/44290#issuecomment-1855084056
Thanks for reviewing, @yaooqinn. I didn't realize you were a committer! You may also be interested in reviewing #44300, which relates to #28274 which you previously worked on back in 2020.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org