You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/19 06:29:08 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #8115: fix: specify function return value

spacewander commented on code in PR #8115:
URL: https://github.com/apache/apisix/pull/8115#discussion_r998991070


##########
CODE_STYLE.md:
##########
@@ -320,6 +320,10 @@ local function check(age, name)
 end
 ```
 
+The function should return `<boolean>`, `err`.

Review Comment:
   Change in the doc should not begin with the prefix "fix"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org