[GitHub] [flink] alpinegizmo commented on a change in pull request #13384: [FLINK-19224][state-processor-api] Support reading window operator state

[GitBox <gi...@apache.org>]

alpinegizmo commented on a change in pull request #13384:
URL: https://github.com/apache/flink/pull/13384#discussion_r489305183



##########
File path: docs/dev/libs/state_processor_api.md
##########
@@ -345,6 +345,44 @@ Along with reading registered state values, each key has access to a `Context` w
 
 {% panel **Note:** When using a `KeyedStateReaderFunction`, all state descriptors must be registered eagerly inside of open. Any attempt to call a `RuntimeContext#get*State` will result in a `RuntimeException`. %}
 
+### Window State
+
+The state processor api supports reading state from a [window operator]({{ site.baseurl }}/dev/stream/operators/windows.html).
+This includes both time based windows along with other types, pre-aggregation, non-aggregated, and windows with evictors.

Review comment:
       This ("along with other types") is vague. I don't see code for handling count windows, or for handling state in Triggers -- but there's a lot of code here, so maybe I missed something. Can we be more precise about what is and isn't supported?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org