You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Hodges (JIRA)" <ji...@apache.org> on 2009/04/26 03:15:32 UTC
[jira] Created: (CASSANDRA-111) Mixed line endings in the codebase
Mixed line endings in the codebase
----------------------------------
Key: CASSANDRA-111
URL: https://issues.apache.org/jira/browse/CASSANDRA-111
Project: Cassandra
Issue Type: Bug
Affects Versions: trunk
Reporter: Jeff Hodges
There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
Also attached is the program that I used to remove them.
Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726773#action_12726773 ]
Jonathan Ellis commented on CASSANDRA-111:
------------------------------------------
I had no idea that existed. Will it deal with the few files that have mixed line endings?
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-111) Mixed line endings in the codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated CASSANDRA-111:
----------------------------------
Attachment: (was: line-endings-r797209.patch)
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726781#action_12726781 ]
Michael Greene commented on CASSANDRA-111:
------------------------------------------
I don't think it would handle them properly, although I'm not sure. You can set individual files to one or the other, or native, but I think you'd have to leave it without an svn:eol-style if you *wanted* to keep it mixed. It'd be better to convert them first if there's no compelling reason for them to be mixed.
http://svnbook.red-bean.com/en/1.1/ch07s02.html#svn-ch-7-sect-2.3.5 is the relevant section of the subversion book.
The algorithm would be:
- find all files we want to have proper eol's
- convert them all to your native system's eol's
- for each filename in files:
- - svn propset svn:eol-style native filename
- commit all files
The above is obviously most easily done with a script.
To keep things nice going forward after this is done, if each committer added the following section to their .subversion/config then new files would automatically have the correct eol style set:
[auto-props]
*.java = svn:eol-style=native
*.properties = svn:eol-style=native
*.py= svn:eol-style=native
*.sh = svn:eol-style=native;svn:executable
*.thrift = svn:eol-style=native
*.txt = svn:eol-style=native
*.xml = svn:eol-style=native
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726704#action_12726704 ]
Jeff Hodges commented on CASSANDRA-111:
---------------------------------------
I like the sound of this deep svn voodoo.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739456#action_12739456 ]
Hudson commented on CASSANDRA-111:
----------------------------------
Integrated in Cassandra #158 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/158/])
fix .properties line endings. patch by jbellis; reviewed by Jeff Hodges for
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Assignee: Jeff Hodges
> Fix For: 0.4
>
> Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, 0001-unix-line-endings-on-799140.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-111) Mixed line endings in the codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated CASSANDRA-111:
----------------------------------
Attachment: line_endings.patch
no.rb
This is the patch file to remove the DOS line endings from the code. no.rb is a ruby program that I ran to create this patch.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737511#action_12737511 ]
Hudson commented on CASSANDRA-111:
----------------------------------
Integrated in Cassandra #153 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/153/])
run source files through dos2unix to standardize on \n line endings. patch by Jeff Hodges; reviewed by Michael Greene for
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Assignee: Jeff Hodges
> Fix For: 0.4
>
> Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, 0001-unix-line-endings-on-799140.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-111) Mixed line endings in the codebase
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-111.
--------------------------------------
Resolution: Fixed
Fix Version/s: 0.4
Assignee: Jeff Hodges
Committed.
190 files changed, 30157 insertions(+), 30157 deletions(-)
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Assignee: Jeff Hodges
> Fix For: 0.4
>
> Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, 0001-unix-line-endings-on-799140.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-111) Mixed line endings in the codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated CASSANDRA-111:
----------------------------------
Attachment: line-endings-r797209.patch
Unix line ending conversion done from code in r797209.
Using this code:
{code}
find . -name "*.java" -print0 -o -name "*.sh" -print0 -o -name "*.xml" -print0 -o -name "*.txt" -print0 | xargs -0 dos2unix
{code}
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: line-endings-r797209.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Evan Weaver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734731#action_12734731 ]
Evan Weaver commented on CASSANDRA-111:
---------------------------------------
I doubt the svn-magic will play well with Git.
Can we switch to Unix endings and be done with it?
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726655#action_12726655 ]
Michael Greene commented on CASSANDRA-111:
------------------------------------------
As long as we standardized on one or the other, as long as we set the svn:eol-style to native things should resolve themselves, right? Windows users see Windows line endings and *X users see *X line endings.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-111) Mixed line endings in the codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated CASSANDRA-111:
----------------------------------
Attachment: 0001-unix-line-endings-on-799140.patch
Since we're seeing more and more mixing of line endings (like in r798935), here is another patch moving cassandra to unix line endings. Patch is against r799140.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, 0001-unix-line-endings-on-799140.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-111) Mixed line endings in the codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Hodges updated CASSANDRA-111:
----------------------------------
Attachment: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch
Corrected unix line endings patch. Last one was an aborted one that someone was renamed. Apologies.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, line-endings-r797209.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702897#action_12702897 ]
Jonathan Ellis commented on CASSANDRA-111:
------------------------------------------
The vast majority of the files use Windows line endings, which makes sense since the original authors develop on Windows. It makes more sense to me to standardize on that, even though I develop on Linux.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734741#action_12734741 ]
Michael Greene commented on CASSANDRA-111:
------------------------------------------
The svn-magic plays just fine with Git, git-svn knows about eol-style. Even so, people not using git-svn and just using git directly would ignore the settings.
Re: Unix endings, yeah, I was suggesting moving to Unix endings. Settings those styles allows editors and platforms without appropriate eol handling to treat them natively though.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736967#action_12736967 ]
Michael Greene commented on CASSANDRA-111:
------------------------------------------
with a trunk cassandra-crlf and a patched cassandra-crlf2 this returns no result:
diff -r -w cassandra-crlf cassandra-crlf2
+1 for applying this immediately. There are no enormous patches in the queue and this doesn't mess with any Windows-specific files.
I still think we should be applying the svn properties and configuration I discuss above, but getting all the files into the correct format is the most important step.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, 0001-unix-line-endings-on-799140.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734828#action_12734828 ]
Jeff Hodges commented on CASSANDRA-111:
---------------------------------------
I don't see anyone that prefers \r\n trying to make this consistent or making noise about wanting consistency. I say the Unix hackers win this one.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jeff Hodges
> Attachments: line-endings-r797209.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702834#action_12702834 ]
Jeff Hodges commented on CASSANDRA-111:
---------------------------------------
Oh, and that program is so ugly because I wanted to be sure I was just replacing "\r\n" and not also adding newlines at the ends of files, etc.
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-111) Mixed line endings in the
codebase
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726723#action_12726723 ]
Sandeep Tata commented on CASSANDRA-111:
----------------------------------------
The mixed line-endings drove me nuts when developing on Windows. Cygwin made everything worse. None of the eol settings in git would do the right thing. Standardizing on one set of endings would be cause for great joy!
> Mixed line endings in the codebase
> ----------------------------------
>
> Key: CASSANDRA-111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-111
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeff Hodges
> Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings. Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them.
> Using Unix line endings in all places makes lots of things easier. At the very least, a consistent choice of line endings would. Has there been discussion of what should be the correct line ending to use?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.