You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/08/21 09:02:14 UTC

[GitHub] [incubator-opendal] Xuanwo created a discussion: refactor: Extract WebdavFs logic to integrations

GitHub user Xuanwo created a discussion: refactor: Extract WebdavFs logic to integrations

Hi, @Young-Flash, do you think it's a good idea to split the `impl WebdavFs for opendal` logic out to integrations? We can maintain a new crate called `dav-server-fs-opendal`.

After this change, our depends will become: `oay` -> `dav-server-fs-opendal` -> `dav-server` & `opendal`.

Benefits:

- Make `oay` a thin wrapper bin instead of bunch of logic here.
- Easier to test for dav related logic.
- `dav-server` ecosystem could use `dav-server-fs-opendal` on their own needs.
- In the future, we can have `dav-server-lock-opendal`.

Also cc dav-server's maintainer @messense for ideas.

GitHub link: https://github.com/apache/incubator-opendal/discussions/2890

----
This is an automatically sent email for commits@opendal.apache.org.
To unsubscribe, please send an email to: commits-unsubscribe@opendal.apache.org


[GitHub] [incubator-opendal] Xuanwo added a comment to the discussion: Extract WebdavFs logic to integrations

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
GitHub user Xuanwo added a comment to the discussion: Extract WebdavFs logic to integrations

I have a discussion with @messense at https://github.com/messense/dav-server-rs/issues/20. We can contribe to upstream once we are stable enough.

GitHub link: https://github.com/apache/incubator-opendal/discussions/2890#discussioncomment-6787936

----
This is an automatically sent email for commits@opendal.apache.org.
To unsubscribe, please send an email to: commits-unsubscribe@opendal.apache.org


[GitHub] [incubator-opendal] Young-Flash added a comment to the discussion: Extract WebdavFs logic to integrations

Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
GitHub user Young-Flash added a comment to the discussion: Extract WebdavFs logic to integrations

Or it is also possible to make `WebdavFs` directly to `dav-server`? But it depends on what @messense thinks

GitHub link: https://github.com/apache/incubator-opendal/discussions/2890#discussioncomment-6787891

----
This is an automatically sent email for commits@opendal.apache.org.
To unsubscribe, please send an email to: commits-unsubscribe@opendal.apache.org


[GitHub] [incubator-opendal] Xuanwo added a comment to the discussion: Extract WebdavFs logic to integrations

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
GitHub user Xuanwo added a comment to the discussion: Extract WebdavFs logic to integrations

Under `integrations/dav-server`.

GitHub link: https://github.com/apache/incubator-opendal/discussions/2890#discussioncomment-6787932

----
This is an automatically sent email for commits@opendal.apache.org.
To unsubscribe, please send an email to: commits-unsubscribe@opendal.apache.org


[GitHub] [incubator-opendal] Young-Flash added a comment to the discussion: Extract WebdavFs logic to integrations

Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
GitHub user Young-Flash added a comment to the discussion: Extract WebdavFs logic to integrations

agree. where will the new crate be? a personal repo or under a organization?

GitHub link: https://github.com/apache/incubator-opendal/discussions/2890#discussioncomment-6787872

----
This is an automatically sent email for commits@opendal.apache.org.
To unsubscribe, please send an email to: commits-unsubscribe@opendal.apache.org


[GitHub] [incubator-opendal] Xuanwo edited a discussion: Extract WebdavFs logic to integrations

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
GitHub user Xuanwo edited a discussion: Extract WebdavFs logic to integrations

Hi, @Young-Flash, do you think it's a good idea to split the `impl WebdavFs for opendal` logic out to integrations? We can maintain a new crate called `dav-server-fs-opendal`.

After this change, our depends will become: `oay` -> `dav-server-fs-opendal` -> `dav-server` & `opendal`.

Benefits:

- Make `oay` a thin wrapper bin instead of bunch of logic here.
- Easier to test for dav related logic.
- `dav-server` ecosystem could use `dav-server-fs-opendal` on their own needs.
- In the future, we can have `dav-server-lock-opendal`.

Also cc dav-server's maintainer @messense for ideas.

GitHub link: https://github.com/apache/incubator-opendal/discussions/2890

----
This is an automatically sent email for commits@opendal.apache.org.
To unsubscribe, please send an email to: commits-unsubscribe@opendal.apache.org