[GitHub] [flink] kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

[GitBox <gi...@apache.org>]

kezhuw commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop
URL: https://github.com/apache/flink/pull/8431#discussion_r283885958
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
 ##########
 @@ -98,12 +96,9 @@ public void init() throws Exception {
 	}
 
 	@Override
-	protected void run() throws Exception {
-		// cache processor reference on the stack, to make the code more JIT friendly
-		final StreamInputProcessor<IN> inputProcessor = this.inputProcessor;
-
-		while (running && inputProcessor.processInput()) {
-			// all the work happens in the "processInput" method
+	protected void performDefaultAction(ActionContext context) throws Exception {
+		if (!inputProcessor.processInput()) {
 
 Review comment:
   This is a blocking operation, it will block until one `StreamRecord` processed. In the meantime, other letters in mailbox such as processing timer are delayed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services