[GitHub] [logging-log4cxx] stephen-webb commented on pull request #40: GitHub actions and OSX fixes

[GitBox <gi...@apache.org>]

stephen-webb commented on pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#issuecomment-690069314


   Yes, using the environment variable would be better, although there is not
   any standard place to look for libraries in Windows AFAIK.
   
   I copied those hints from another project without understanding the reason
   they were chosen.
   
   On Thu, Sep 10, 2020 at 5:45 PM Thorsten Schöning <no...@github.com>
   wrote:
   
   > *@ams-tschoening* commented on this pull request.
   > ------------------------------
   >
   > In src/cmake/FindAPR-Util.cmake
   > <https://github.com/apache/logging-log4cxx/pull/40#discussion_r486133337>:
   >
   > > @@ -29,7 +29,7 @@ endmacro(_apu_invoke)
   >
   >  find_program(APR_UTIL_CONFIG_EXECUTABLE
   >      apu-1-config
   > -    PATHS /usr/local/bin    /usr/bin    C:/Progra~1/apr-util/bin
   > +    PATHS /usr/local/bin    /usr/bin    C:/Progra~1/apr-util/bin /usr/local/opt/apr-util/bin
   >
   > @stephen-webb <https://github.com/stephen-webb> Should we change
   > C:/Progra~1/apr-util/bin to become %ProgramFiles%/apr-util/bin or does it
   > break for you? Using the environment variable instead of the concrete
   > directory name looks more correct to me.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/logging-log4cxx/pull/40#discussion_r486133337>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ANLOSDXK6U4DCO2AHGHKETDSFB727ANCNFSM4Q65NIIQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org