You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Mike Hefner (JIRA)" <ji...@apache.org> on 2010/10/22 04:00:16 UTC
[jira] Created: (WICKET-3127) Adding node to a collapsed tree node
should not cause it to expand
Adding node to a collapsed tree node should not cause it to expand
------------------------------------------------------------------
Key: WICKET-3127
URL: https://issues.apache.org/jira/browse/WICKET-3127
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.13, 1.5-M3
Reporter: Mike Hefner
Priority: Minor
The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3127) Adding node to a collapsed tree node
should not cause it to expand
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3127.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M3
1.4.13
Patch applied to both 1.4.x and 1.5.x.
Thanks!
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: WICKET-3127-fix.patch, WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3127) Adding node to a
collapsed tree node should not cause it to expand
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924004#action_12924004 ]
Martin Grigorov edited comment on WICKET-3127 at 10/22/10 4:22 PM:
-------------------------------------------------------------------
The patch looks OK and works fine with the quickstart application. The collapsed node does not expand when adding new sub-node.
-Brix demo admin > menus still expands ...-
*Update*: My bad. I was testing against the old wicket-1.4-SNAPSHOT.jar
Adding and removing nodes work OK until I try to remove the root node. The quickstart fails due to its own problem, brix removes the root but then cannot add new root...
>From Wicket side everything looks ok, so I will commit the patch.
was (Author: mgrigorov):
The patch looks OK and works fine with the quickstart application. The collapsed node does not expand when adding new sub-node.
Brix demo admin > menus still expands ...
Adding and removing nodes work OK until I try to remove the root node. The quickstart fails due to its own problem, brix removes the root but then cannot add new root...
>From Wicket side everything looks ok, so I will commit the patch.
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: WICKET-3127-fix.patch, WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3127) Adding node to a collapsed tree
node should not cause it to expand
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924038#action_12924038 ]
Hudson commented on WICKET-3127:
--------------------------------
Integrated in Apache Wicket 1.5.x #441 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/441/])
WICKET-3127 Adding node to a collapsed tree node should not cause it to expand
Do not expand a collapsed non-leaf node when adding a sub-node to it.
patch-provided-by: Mike Hefner
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: WICKET-3127-fix.patch, WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3127) Adding node to a collapsed tree node
should not cause it to expand
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3127:
---------------------------------------
Assignee: Martin Grigorov
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: WICKET-3127-fix.patch, WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3127) Adding node to a collapsed tree
node should not cause it to expand
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924004#action_12924004 ]
Martin Grigorov commented on WICKET-3127:
-----------------------------------------
The patch looks OK and works fine with the quickstart application. The collapsed node does not expand when adding new sub-node.
Brix demo admin > menus still expands ...
Adding and removing nodes work OK until I try to remove the root node. The quickstart fails due to its own problem, brix removes the root but then cannot add new root...
>From Wicket side everything looks ok, so I will commit the patch.
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: WICKET-3127-fix.patch, WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3127) Adding node to a collapsed tree
node should not cause it to expand
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924030#action_12924030 ]
Hudson commented on WICKET-3127:
--------------------------------
Integrated in Apache Wicket 1.4.x #225 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/225/])
WICKET-3127 Adding node to a collapsed tree node should not cause it to expand
Do not expand a collapsed non-leaf node when adding a sub-node to it.
patch-provided-by: Mike Hefner
merge-from-1.4: r1026477
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: WICKET-3127-fix.patch, WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3127) Adding node to a collapsed tree node
should not cause it to expand
Posted by "Mike Hefner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Hefner updated WICKET-3127:
--------------------------------
Attachment: WICKET-3127-QuickStart.zip
Attached QuickStart demonstrating the problem.
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Priority: Minor
> Attachments: WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3127) Adding node to a collapsed tree node
should not cause it to expand
Posted by "Mike Hefner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Hefner updated WICKET-3127:
--------------------------------
Attachment: WICKET-3127-fix.patch
Attached patch.
Patch has been tested against org.apache.wicket.markup.html.tree.LinkTree and org.apache.wicket.extensions.markup.html.tree.Tree.
Also tested against the tree component on brix-demo admin page, Menus tab
> Adding node to a collapsed tree node should not cause it to expand
> ------------------------------------------------------------------
>
> Key: WICKET-3127
> URL: https://issues.apache.org/jira/browse/WICKET-3127
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Mike Hefner
> Priority: Minor
> Attachments: WICKET-3127-fix.patch, WICKET-3127-QuickStart.zip
>
>
> The fix for WICKET-3112 made a unwanted minor modification to the Tree behavior that was established in WICKET-2886.
> Adding a child to a tree node that already has children and that is currently collapsed now causes the parent node to expand so that all the children are displayed. Only adding the first child to a node should cause it to expand, in all other cases the state of the parent node should not change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.