You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/05/03 20:55:40 UTC

[GitHub] [avro] blacktooth opened a new pull request #1210: AVRO-3129: Throw SchemaParseException when enum symbol is null

blacktooth opened a new pull request #1210:
URL: https://github.com/apache/avro/pull/1210

Avro Schema parser fails with NullPointerException when a schema with null Enum symbols are encountered. This behavior is inconsistent with using an empty symbol where a SchemaParseException is thrown. JIRA: https://issues.apache.org/jira/browse/AVRO-3129

Make sure you have checked _all_ steps below.

### Jira

- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO-3129) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3129
- [X] In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).

### Tests

- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:

`testEnumSymbolAsNull`

### Commits

- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"

### Documentation

Not applicable.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] Fokko merged pull request #1210: AVRO-3129: Throw SchemaParseException when enum symbol is null

Posted by GitBox <gi...@apache.org>.

Fokko merged pull request #1210:
URL: https://github.com/apache/avro/pull/1210


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] Fokko commented on pull request #1210: AVRO-3129: Throw SchemaParseException when enum symbol is null

Posted by GitBox <gi...@apache.org>.

Fokko commented on pull request #1210:
URL: https://github.com/apache/avro/pull/1210#issuecomment-835892892


   @blacktooth Yes, this looks good to me. Wanted to give other committers/contributors also some time for reviewing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] blacktooth commented on pull request #1210: AVRO-3129: Throw SchemaParseException when enum symbol is null

Posted by GitBox <gi...@apache.org>.

blacktooth commented on pull request #1210:
URL: https://github.com/apache/avro/pull/1210#issuecomment-834782777


   Hello, thanks for approving!
   
   Will this change be merged into master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org