You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/05/05 14:30:15 UTC

svn commit: r1742431 - /jmeter/trunk/bin/jmeter.properties

Author: pmouawad
Date: Thu May  5 14:30:15 2016
New Revision: 1742431

URL: http://svn.apache.org/viewvc?rev=1742431&view=rev
Log:
Fix documentation error
CLarify sentence

Modified:
    jmeter/trunk/bin/jmeter.properties

Modified: jmeter/trunk/bin/jmeter.properties
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742431&r1=1742430&r2=1742431&view=diff
==============================================================================
--- jmeter/trunk/bin/jmeter.properties (original)
+++ jmeter/trunk/bin/jmeter.properties Thu May  5 14:30:15 2016
@@ -463,16 +463,15 @@ log_level.jorphan=INFO
 #httpclient4.retrycount=0
 
 # Idle connection timeout (Milliseconds) to apply if the server does not send
-# Keep-Alive headers (default 0 = no Keep-Alive)
+# Keep-Alive headers (default 0 = no suggested duration for Keep-Alive)
 #httpclient4.idletimeout=0
-# Note: this is currently an experimental fix
 
 # Check connections if the elapsed time (Milliseconds) since the last 
 # use of the connection exceed this value
 #httpclient4.validate_after_inactivity=2000
 
 # TTL (in Milliseconds) represents an absolute value. 
-# No matter what the connection will not be re-used beyond its TTL. 
+# No matter what, the connection will not be re-used beyond its TTL. 
 #httpclient4.time_to_live=2000
 
 #---------------------------------------------------------------------------



Re: svn commit: r1742431 - /jmeter/trunk/bin/jmeter.properties

Posted by sebb <se...@gmail.com>.
On 5 May 2016 at 15:30,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Thu May  5 14:30:15 2016
> New Revision: 1742431
>
> URL: http://svn.apache.org/viewvc?rev=1742431&view=rev
> Log:
> Fix documentation error
> CLarify sentence
>
> Modified:
>     jmeter/trunk/bin/jmeter.properties
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742431&r1=1742430&r2=1742431&view=diff
> ==============================================================================
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Thu May  5 14:30:15 2016
> @@ -463,16 +463,15 @@ log_level.jorphan=INFO
>  #httpclient4.retrycount=0
>
>  # Idle connection timeout (Milliseconds) to apply if the server does not send
> -# Keep-Alive headers (default 0 = no Keep-Alive)
> +# Keep-Alive headers (default 0 = no suggested duration for Keep-Alive)

I agree the original was unclear, but I'm afraid the new text doesn't
help me understand what JMeter will do.
Nor is the HC docn all that clear (which is where I assume the text originated)
I have tried to explain further in my last commit

>  #httpclient4.idletimeout=0
> -# Note: this is currently an experimental fix
>
>  # Check connections if the elapsed time (Milliseconds) since the last
>  # use of the connection exceed this value
>  #httpclient4.validate_after_inactivity=2000
>
>  # TTL (in Milliseconds) represents an absolute value.
> -# No matter what the connection will not be re-used beyond its TTL.
> +# No matter what, the connection will not be re-used beyond its TTL.

Good catch

>  #httpclient4.time_to_live=2000
>
>  #---------------------------------------------------------------------------
>
>