[GitHub] [incubator-pekko-persistence-dynamodb] coreyoconnor commented on pull request #12: Add setSelect(ALL_ATTRIBUTES) to retrieve snapshots

["coreyoconnor (via GitHub)" <gi...@apache.org>]

coreyoconnor commented on PR #12:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/12#issuecomment-1442695820

   Looks like a nice change!
   
   Two thoughts:
   
   1. That comment on the tradeoff depending on how the index is configured should be copied here: https://github.com/apache/incubator-pekko-persistence-dynamodb/blob/27f9e016b2cc610e66e28b75bb7305d1e5ef4cee/src/main/scala/akka/persistence/dynamodb/query/scaladsl/DynamoDBCurrentPersistenceIdsQuery.scala#L64
   1. I think this kind of change will need a minor version bump. Depending on how the secondary index is configured, an existing user may see a difference in behavior/performance with the version that includes this.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org