You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "yangzhang75 (via GitHub)" <gi...@apache.org> on 2026/09/17 20:44:21 UTC

[PR] feat(frontend): mark the public version, open what a listing advertises, and turn pinning on [texera]

yangzhang75 opened a new pull request, #8579:
URL: https://github.com/apache/texera/pull/8579

   ### What changes were proposed in this PR?
   
   Two places outside the share dialog have to agree with the pin, and then the feature is complete.
   
   - **The versions panel marks the version the Hub is serving**, as a quiet second line under its
     timestamp rather than a tag: the panel is 230px wide, so horizontal room is scarce while
     vertical room is free. That row is also how an author who has moved on gets the published copy
     back — it is already in the panel, so restoring it is the restore they already know. The panel
     re-reads when the share dialog closes, since that is where the pin can have moved and the panel
     is covered until then.
   - **Hub entries open what they advertise.** A hub card shows the public copy, so an author whose
     working copy has moved on behind a pin now lands on the published preview — what they just saw,
     and where Clone gives them a copy of it — rather than in their editor showing something else.
     Their own listings are untouched: there the entry is their workflow.
   - **The flag goes on.** `gui.workflow-workspace.version-pinning-enabled` flips to `true`, which is
     what makes the switch appear in the share dialog. It is deliberately the last change of the
     series: every surface that has to agree with a pin is in place by the time an author can make
     one. Nothing downstream needed its own gate — a listing marker and a hub link both depend on a
     pin existing, and no pin can exist while the control is hidden.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7943
   Part of #7828. Design discussion: #7128. Stacked on #7853, #8575, #8576, #8577 and #8578; until
   those merge this PR shows their commits too, and the review here is the last one.
   
   **This is the PR that turns the feature on.** It should merge last.
   
   ### How was this PR tested?
   
   Frontend: the versions-list spec covers the marker appearing only on the version the Hub serves
   and the panel re-reading when the announcement comes; the menu spec covers the announcement being
   made when the share dialog closes, and not when the user has just revoked their own access and is
   being navigated away; the registry spec covers the routing rule — a hub entry whose public copy
   is behind goes to the preview, one that is not goes to the editor, and a private-search row is
   never diverted; the card and list specs cover the argument reaching the rule. Full suite passes
   (5989), production (AOT) build passes, prettier clean.
   
   Backend: `GuiConfigSpec` now pins the flag's default to on (72 tests); the dashboard package
   passes (567); scalafmt clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): mark the public version, open what a listing advertises, and turn pinning on [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8579:
URL: https://github.com/apache/texera/pull/8579#issuecomment-5721005910

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8579?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `89.70588%` with `7 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 92.90%. Comparing base ([`f9b899a`](https://app.codecov.io/gh/apache/texera/commit/f9b899a52890347d8d44c72c325863ff96fcb714?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2357f74`](https://app.codecov.io/gh/apache/texera/commit/2357f7454e91017ba445d9f4e3fb6c17d109f32a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 9 commits behind head on main.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/8579?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...shboard/user/workflow/WorkflowPublishService.scala](https://app.codecov.io/gh/apache/texera/pull/8579?src=pr&el=tree&filepath=amber%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fweb%2Fresource%2Fdashboard%2Fuser%2Fworkflow%2FWorkflowPublishService.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1iZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvd2ViL3Jlc291cmNlL2Rhc2hib2FyZC91c2VyL3dvcmtmbG93L1dvcmtmbG93UHVibGlzaFNlcnZpY2Uuc2NhbGE=) | 85.10% | [1 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/8579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #8579      +/-   ##
   ============================================
   - Coverage     92.91%   92.90%   -0.02%     
   - Complexity     4884     4888       +4     
   ============================================
     Files          1224     1225       +1     
     Lines         51298    51296       -2     
     Branches       6322     6332      +10     
   ============================================
   - Hits          47664    47654      -10     
   - Misses         2070     2071       +1     
   - Partials       1564     1571       +7     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.78% <ø> (ø)` | | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.96% <89.55%> (-0.05%)` | :arrow_down: | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.61% <ø> (ø)` | | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.50% <100.00%> (+0.24%)` | :arrow_up: | |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.68% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.47% <ø> (ø)` | | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [8e67384](https://app.codecov.io/gh/apache/texera/commit/8e673842273e7d440643284631965f3ff411d479?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8579?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): mark the public version, open what a listing advertises, and turn pinning on [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8579:
URL: https://github.com/apache/texera/pull/8579#issuecomment-5721049060

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 2 better · 🔴 4 worse · ⚪ 9 noise (<±5%) · 0 without baseline
   
   > Compared against main `471e53c` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/35272613821)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 397 | 0.242 | 23,128/38,481/38,481 us | 🔴 +17.3% / 🔴 +157.0% |
   | 🟢 | bs=100 sw=10 sl=64 | 938 | 0.573 | 105,355/124,151/124,151 us | 🟢 -15.0% / 🔴 +24.2% |
   | ⚪ | bs=1000 sw=10 sl=64 | 1,084 | 0.662 | 925,768/985,701/985,701 us | ⚪ within ±5% / ⚪ within ±5% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `471e53c` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 397 tuples/sec | 447 tuples/sec | 839.58 tuples/sec | -11.2% | -52.7% |
   | bs=10 sw=10 sl=64 | MB/s | 0.242 MB/s | 0.273 MB/s | 0.512 MB/s | -11.4% | -52.8% |
   | bs=10 sw=10 sl=64 | p50 | 23,128 us | 22,347 us | 11,937 us | +3.5% | +93.8% |
   | bs=10 sw=10 sl=64 | p95 | 38,481 us | 32,816 us | 14,976 us | +17.3% | +157.0% |
   | bs=10 sw=10 sl=64 | p99 | 38,481 us | 32,816 us | 19,204 us | +17.3% | +100.4% |
   | bs=100 sw=10 sl=64 | throughput | 938 tuples/sec | 922 tuples/sec | 1,096 tuples/sec | +1.7% | -14.4% |
   | bs=100 sw=10 sl=64 | MB/s | 0.573 MB/s | 0.563 MB/s | 0.669 MB/s | +1.8% | -14.3% |
   | bs=100 sw=10 sl=64 | p50 | 105,355 us | 103,069 us | 94,033 us | +2.2% | +12.0% |
   | bs=100 sw=10 sl=64 | p95 | 124,151 us | 146,046 us | 99,939 us | -15.0% | +24.2% |
   | bs=100 sw=10 sl=64 | p99 | 124,151 us | 146,046 us | 110,148 us | -15.0% | +12.7% |
   | bs=1000 sw=10 sl=64 | throughput | 1,084 tuples/sec | 1,100 tuples/sec | 1,128 tuples/sec | -1.5% | -3.9% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.662 MB/s | 0.671 MB/s | 0.688 MB/s | -1.3% | -3.8% |
   | bs=1000 sw=10 sl=64 | p50 | 925,768 us | 909,445 us | 921,191 us | +1.8% | +0.5% |
   | bs=1000 sw=10 sl=64 | p95 | 985,701 us | 958,191 us | 959,735 us | +2.9% | +2.7% |
   | bs=1000 sw=10 sl=64 | p99 | 985,701 us | 958,191 us | 988,604 us | +2.9% | -0.3% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,503.96,200,128000,397,0.242,23128.24,38480.89,38480.89
   1,100,10,64,20,2131.99,2000,1280000,938,0.573,105355.45,124150.69,124150.69
   2,1000,10,64,20,18446.39,20000,12800000,1084,0.662,925768.46,985701.08,985701.08
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(frontend): mark the public version, open what a listing advertises, and turn pinning on [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8579:
URL: https://github.com/apache/texera/pull/8579#issuecomment-5720988171

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@aglinxinyuan`, `@tanishqgandhi1908`, `@mengw15`
     You can notify them by mentioning `@aglinxinyuan`, `@tanishqgandhi1908`, `@mengw15` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org