[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5762: Enhance log message in FirstFitPlanner

[GitBox <gi...@apache.org>]

GabrielBrascher commented on a change in pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#discussion_r765920335



##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -367,8 +372,11 @@ protected void removeClustersCrossingThreshold(List<Long> clusterListForVmAlloca
                 // Remove clusters crossing disabled threshold
                 clusterListForVmAllocation.removeAll(clustersCrossingThreshold);
 
-                s_logger.debug("Cannot allocate cluster list " + clustersCrossingThreshold.toString() + " for vm creation since their allocated percentage" +
-                        " crosses the disable capacity threshold defined at each cluster/ at global value for capacity Type : " + capacity + ", skipping these clusters");
+                String warnMessageForClusterReachedCapacityThreshold = String.format(
+                        "Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
+                                + " global value [settings: %s, value: %s] for capacity Type : %s, skipping these clusters", clustersCrossingThreshold.toString(),

Review comment:
       @DaanHoogland updated the code to fit with your suggestion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org