You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/16 02:56:50 UTC
[GitHub] [pulsar] RobertIndie commented on a diff in pull request #15880: [improve][broker] Make some operation subscription dispatchRate methods in Namespaces async
RobertIndie commented on code in PR #15880:
URL: https://github.com/apache/pulsar/pull/15880#discussion_r898646588
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -1385,46 +1385,32 @@ protected CompletableFuture<DispatchRate> internalGetTopicDispatchRateAsync() {
.thenApply(policies -> policies.topicDispatchRate.get(pulsar().getConfiguration().getClusterName()));
}
- protected void internalSetSubscriptionDispatchRate(DispatchRateImpl dispatchRate) {
- validateSuperUserAccess();
- log.info("[{}] Set namespace subscription dispatch-rate {}/{}", clientAppId(), namespaceName, dispatchRate);
-
- try {
- updatePolicies(namespaceName, (policies) -> {
- policies.subscriptionDispatchRate.put(pulsar().getConfiguration().getClusterName(), dispatchRate);
- return policies;
- });
- log.info("[{}] Successfully updated the subscriptionDispatchRate for cluster on namespace {}",
- clientAppId(), namespaceName);
- } catch (Exception e) {
- log.error("[{}] Failed to update the subscriptionDispatchRate for cluster on namespace {}", clientAppId(),
- namespaceName, e);
- throw new RestException(e);
- }
+ protected CompletableFuture<Void> internalSetSubscriptionDispatchRateAsync(DispatchRateImpl dispatchRate) {
+ return validateSuperUserAccessAsync()
+ .thenCompose(__ -> updatePoliciesAsync(namespaceName, policies -> {
+ policies.subscriptionDispatchRate.put(pulsar().getConfiguration().getClusterName(), dispatchRate);
+ log.info("[{}] Successfully updated the subscriptionDispatchRate for cluster on namespace {}",
+ clientAppId(), namespaceName);
+ return policies;
+ }));
}
- protected void internalDeleteSubscriptionDispatchRate() {
- validateSuperUserAccess();
-
- try {
- updatePolicies(namespaceName, policies -> {
- policies.subscriptionDispatchRate.remove(pulsar().getConfiguration().getClusterName());
- return policies;
- });
- log.info("[{}] Successfully delete the subscriptionDispatchRate for cluster on namespace {}",
- clientAppId(), namespaceName);
- } catch (Exception e) {
- log.error("[{}] Failed to delete the subscriptionDispatchRate for cluster on namespace {}", clientAppId(),
- namespaceName, e);
- throw new RestException(e);
- }
+ protected CompletableFuture<Void> internalDeleteSubscriptionDispatchRateAsync() {
+ return validateSuperUserAccessAsync()
+ .thenCompose(__ -> updatePoliciesAsync(namespaceName, policies -> {
+ policies.subscriptionDispatchRate.remove(pulsar().getConfiguration().getClusterName());
+ log.info("[{}] Successfully delete the subscriptionDispatchRate for cluster on namespace {}",
+ clientAppId(), namespaceName);
+ return policies;
+ }));
}
- protected DispatchRate internalGetSubscriptionDispatchRate() {
+ protected CompletableFuture<DispatchRate> internalGetSubscriptionDispatchRateAsync() {
validateNamespacePolicyOperation(namespaceName, PolicyName.RATE, PolicyOperation.READ);
Review Comment:
Need to remove this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org