[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8472: [statsd-emitter] Fix service tag by avoiding using a reserved word

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #8472: [statsd-emitter] Fix service tag by avoiding using a reserved word
URL: https://github.com/apache/incubator-druid/pull/8472#discussion_r321401846
 
 

 ##########
 File path: extensions-contrib/statsd-emitter/src/test/java/org/apache/druid/emitter/statsd/StatsDEmitterTest.java
 ##########
 @@ -181,7 +181,7 @@ public void testServiceAsTagOption()
             client
     );
     client.time("druid.query.time", 10,
-            "service:druid/broker", "dataSource:data-source", "type:groupBy", "hostname:brokerHost1"
+            "druidService:druid/broker", "dataSource:data-source", "type:groupBy", "hostname:brokerHost1"
 
 Review comment:
   Is there any way to test that reserved tag keys are not used?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org